tiltfile: Add disable_push option to build_docker function

[cm226]

Added a disable_push flag to the docker_build function, we wanted this for our CI environment.
We use minikube in our CI deployment, and share a docker socket with the build environment, so no need to push images.

Went with a flag per image, because I could "sort-of" imagine cases where it might be useful to be able have different push behavior per image, although willing to be corrected on that

resolves #1730

[nicks]

hello! i'm a little bit confused by the bug report -- tilt should automatically detect when minikube is exposing it's docker socket, and skip the push in this case. (note that the issue you linked to mentions this). can you share the output of tilt doctor and how your minikube env is set up?

for background --

the comment you linked to was written 5 years ago, so we've learned a lot since then! i think most of us agree that adding disable_push to custom_build was a mistake. it's difficult to use correctly, and then people have to add more workarounds to fix the problems it creates. so these days we lean more towards reading the configuration off the cluster, rather than adding it to the tiltfile.

[cm226]

Hi, Thanks for getting back @nicks.

I understand re background info.

Our use case is we are running minikube as part of a CI job. The host that the CI job runs on is shared with other jobs/users, who may also be running minikube. So we create a cluster with a custom name. We are guessing this is why tilt is not detecting that the cluster its deploying to is minikube. Sorry I have been meaning to have a look at tilts behaviour to confirm this, but haven't had time yet.

If true, does tilt have some way of supporting this?

thanks

[nicks]

does it fix the issue if you make sure the cluster has the prefix minikube?

[nicks]

(i'm pretty sure tilt uses other ways of detecting that the cluster is minikube that will work even if the cluster is renamed, but changing the name will at least test if our hypothesis is correct)

what does tilt doctor say?