Update custom post type criteria

[connorjburton]

I feel like limiting the post types that the acf field gets added to is currently incorrect, let says you have some blocks on a homepage that you want to be able to query using get_posts but you don't want each individually viewable, you would set that post_type to public: false, publicly_queryable: true

The small change I PR'd fixes this scenario, allowing you to see ACF fields for those types of post types.

[chrishutchinson]

Sounds good - would there ever be a case that 'publicly_queryable' => true wouldn't pick up a post type that 'public' => true would?

I can't recall of the top of my head how each will work?

[connorjburton]

Hmm good point, it may need to check if public or publicly_queryable are true then.

[connorjburton]

Maybe there is a better way, you have to add show_in_rest when registering a custom post type to be included in the WP API, couldn't we just query by that.

My second thought is does WP API do any checks on custom post types, or does it just let any CPT with show_in_rest return data. We should probably match what WP API does.