Add singapore to deploy matrix #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
adolsalamanca
commented
Sep 14, 2023
•
adolsalamanca
commented
- Adds singapore to the deploy matrix
- Stop downloading actionlin on each run, use a pre-built action instead.
- Fixes lint in this actions.
adolsalamanca
force-pushed
the
adol/add-singapore-to-matrix
branch
2 times, most recently
from
304114e
to
c70bf5a
Compare
minkimipt
approved these changes
Sep 14, 2023
minkimipt
reviewed
Sep 14, 2023
.github/workflows/linter.yaml
Outdated
Comment on lines
21
to
25
| - uses: reviewdog/action-actionlint@v1 | ||
| with: | ||
| actionlint_flags: -ignore SC2086 -config-file .github/actionlint.yaml | ||
| fail_on_error: true | ||
| level: error |
adolsalamanca
force-pushed
the
adol/add-singapore-to-matrix
branch
from
c70bf5a
to
90bdd70
Compare
adolsalamanca
force-pushed
the
adol/add-singapore-to-matrix
branch
from
90bdd70
to
f5791cc
Compare
adolsalamanca
added a commit
that referenced
this pull request
Sep 14, 2023
* add singapore to matrix * Use actionlint instead of download it * fix lint
adolsalamanca
added a commit
that referenced
this pull request
Sep 14, 2023
* add singapore to matrix * Use actionlint instead of download it * fix lint
adolsalamanca
added a commit
that referenced
this pull request
Sep 14, 2023
* add singapore to matrix * Use actionlint instead of download it * fix lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.