Skip to content

PR Approval Check #1161

PR Approval Check

PR Approval Check #1161

Workflow file for this run

# All PRs except trivial ones should require 2 approvals, since this a global setting
# we cannot make this decision from github configuration alone. So we set the required
# approved in github to 1 and make this check required which will enforce 2 approvals
# unless overwritten or only CI files are touched.
name: PR Approval Check
"on":
pull_request:
types: [opened, synchronize, reopened, edited, auto_merge_enabled, auto_merge_disabled]
branches: [main]
pull_request_review:
jobs:
check_approvals:
name: Check for sufficient approvals
runs-on: ubuntu-latest
steps:
- name: Checkout source
uses: actions/checkout@v4
- name: Check for sufficient approvals
shell: bash --norc --noprofile {0}
env:
BODY: ${{ github.event.pull_request.body }}
GH_TOKEN: ${{ github.token }}
PR_NUMBER: ${{ github.event.number }}
run: |
echo "PR number is $PR_NUMBER"
echo "$BODY" | egrep -qsi '^disable-check:.*\<approval-count\>'
if [[ $? -ne 0 ]]; then
# Get the list of modified files in this pull request
echo "Modified files: "
gh pr view $PR_NUMBER --json files
# Get the number of modified files, but exclude those that
# are workflow files or are related to Hypercore table
# access method. These require only a single reviewer.
files=$(gh pr view $PR_NUMBER --json files --jq '[.files.[].path | select(startswith(".github") or test("hypercore|columnar_scan") | not)] | length')
# Get the number of approvals in this pull request
echo "Reviews: "
gh pr view $PR_NUMBER --json reviews
approvals=$(
gh pr view $PR_NUMBER --json reviews --jq '
[
.reviews.[]
| select(
(
.authorAssociation == "NONE"
or .authorAssociation == "MEMBER"
or .authorAssociation == "CONTRIBUTOR"
)
and .state == "APPROVED"
)
] | length
'
)
echo "approvals: $approvals, files: $files"
if [[ $approvals -lt 2 ]] && [[ $files -gt 0 ]] ; then
echo "This pull request requires 2 approvals before merging."
echo
echo "For trivial changes, you may disable this check by adding this trailer to the pull request message:"
echo
echo "Disable-check: approval-count"
echo
exit 1
fi
fi