Make CAggs materialized only by default

timescale · Sep 15, 2023 · 1746cf4 · 1746cf4
1 parent edf0bfa
commit 1746cf4
Show file tree

Hide file tree

Showing 69 changed files with 883 additions and 883 deletions.
diff --git a/src/ts_catalog/continuous_agg.c b/src/ts_catalog/continuous_agg.c
@@ -58,7 +58,7 @@ static const WithClauseDefinition continuous_aggregate_with_clause_def[] = {
 		[ContinuousViewOptionMaterializedOnly] = {
 			.arg_name = "materialized_only",
 			.type_id = BOOLOID,
-			.default_val = (Datum)false,
+			.default_val = (Datum)true,
 		},
 		[ContinuousViewOptionCompress] = {
 			.arg_name = "compress",

diff --git a/tsl/test/expected/bgw_custom.out b/tsl/test/expected/bgw_custom.out
@@ -514,7 +514,7 @@ SELECT decompress_chunk(c) FROM show_chunks('conditions') c;
 
 -- TEST Continuous Aggregate job
 CREATE MATERIALIZED VIEW conditions_summary_daily
-WITH (timescaledb.continuous) AS
+WITH (timescaledb.continuous, timescaledb.materialized_only=false) AS
 SELECT location,
    time_bucket(INTERVAL '1 day', time) AS bucket,
    AVG(temperature),

diff --git a/tsl/test/expected/cagg_ddl.out b/tsl/test/expected/cagg_ddl.out
@@ -1097,65 +1097,65 @@ FROM (
 (3 rows)
 
 -- width expression for int2 hypertables
-CREATE MATERIALIZED VIEW width_expr WITH (timescaledb.continuous) AS
+CREATE MATERIALIZED VIEW width_expr WITH (timescaledb.continuous, timescaledb.materialized_only=false) AS
 SELECT time_bucket(1::smallint, time)
 FROM metrics_int2
 GROUP BY 1;
 psql:include/cagg_ddl_common.sql:750: NOTICE:  continuous aggregate "width_expr" is already up-to-date
 DROP MATERIALIZED VIEW width_expr;
-CREATE MATERIALIZED VIEW width_expr WITH (timescaledb.continuous) AS
+CREATE MATERIALIZED VIEW width_expr WITH (timescaledb.continuous, timescaledb.materialized_only=false) AS
 SELECT time_bucket(1::smallint + 2::smallint, time)
 FROM metrics_int2
 GROUP BY 1;
 psql:include/cagg_ddl_common.sql:757: NOTICE:  continuous aggregate "width_expr" is already up-to-date
 DROP MATERIALIZED VIEW width_expr;
 -- width expression for int4 hypertables
-CREATE MATERIALIZED VIEW width_expr WITH (timescaledb.continuous) AS
+CREATE MATERIALIZED VIEW width_expr WITH (timescaledb.continuous, timescaledb.materialized_only=false) AS
 SELECT time_bucket(1, time)
 FROM metrics_int4
 GROUP BY 1;
 psql:include/cagg_ddl_common.sql:765: NOTICE:  continuous aggregate "width_expr" is already up-to-date
 DROP MATERIALIZED VIEW width_expr;
-CREATE MATERIALIZED VIEW width_expr WITH (timescaledb.continuous) AS
+CREATE MATERIALIZED VIEW width_expr WITH (timescaledb.continuous, timescaledb.materialized_only=false) AS
 SELECT time_bucket(1 + 2, time)
 FROM metrics_int4
 GROUP BY 1;
 psql:include/cagg_ddl_common.sql:772: NOTICE:  continuous aggregate "width_expr" is already up-to-date
 DROP MATERIALIZED VIEW width_expr;
 -- width expression for int8 hypertables
-CREATE MATERIALIZED VIEW width_expr WITH (timescaledb.continuous) AS
+CREATE MATERIALIZED VIEW width_expr WITH (timescaledb.continuous, timescaledb.materialized_only=false) AS
 SELECT time_bucket(1, time)
 FROM metrics_int8
 GROUP BY 1;
 psql:include/cagg_ddl_common.sql:780: NOTICE:  continuous aggregate "width_expr" is already up-to-date
 DROP MATERIALIZED VIEW width_expr;
-CREATE MATERIALIZED VIEW width_expr WITH (timescaledb.continuous) AS
+CREATE MATERIALIZED VIEW width_expr WITH (timescaledb.continuous, timescaledb.materialized_only=false) AS
 SELECT time_bucket(1 + 2, time)
 FROM metrics_int8
 GROUP BY 1;
 psql:include/cagg_ddl_common.sql:787: NOTICE:  continuous aggregate "width_expr" is already up-to-date
 DROP MATERIALIZED VIEW width_expr;
 \set ON_ERROR_STOP 0
 -- non-immutable expresions should be rejected
-CREATE MATERIALIZED VIEW width_expr WITH (timescaledb.continuous) AS
+CREATE MATERIALIZED VIEW width_expr WITH (timescaledb.continuous, timescaledb.materialized_only=false) AS
 SELECT time_bucket(extract(year FROM now())::smallint, time)
 FROM metrics_int2
 GROUP BY 1;
 psql:include/cagg_ddl_common.sql:796: ERROR:  only immutable expressions allowed in time bucket function
-CREATE MATERIALIZED VIEW width_expr WITH (timescaledb.continuous) AS
+CREATE MATERIALIZED VIEW width_expr WITH (timescaledb.continuous, timescaledb.materialized_only=false) AS
 SELECT time_bucket(extract(year FROM now())::int, time)
 FROM metrics_int4
 GROUP BY 1;
 psql:include/cagg_ddl_common.sql:801: ERROR:  only immutable expressions allowed in time bucket function
-CREATE MATERIALIZED VIEW width_expr WITH (timescaledb.continuous) AS
+CREATE MATERIALIZED VIEW width_expr WITH (timescaledb.continuous, timescaledb.materialized_only=false) AS
 SELECT time_bucket(extract(year FROM now())::int, time)
 FROM metrics_int8
 GROUP BY 1;
 psql:include/cagg_ddl_common.sql:806: ERROR:  only immutable expressions allowed in time bucket function
 \set ON_ERROR_STOP 1
 -- Test various ALTER MATERIALIZED VIEW statements.
 SET ROLE :ROLE_DEFAULT_PERM_USER;
-CREATE MATERIALIZED VIEW owner_check WITH (timescaledb.continuous) AS
+CREATE MATERIALIZED VIEW owner_check WITH (timescaledb.continuous, timescaledb.materialized_only=false) AS
 SELECT time_bucket(1 + 2, time)
 FROM metrics_int8
 GROUP BY 1
@@ -1293,7 +1293,7 @@ SELECT create_hypertable('test_schema.telemetry_raw', 'ts');
 
 \endif
 CREATE MATERIALIZED VIEW test_schema.telemetry_1s
-  WITH (timescaledb.continuous)
+  WITH (timescaledb.continuous, timescaledb.materialized_only=false)
     AS
 SELECT time_bucket(INTERVAL '1s', ts) AS ts_1s,
        avg(value)
@@ -1356,14 +1356,14 @@ SELECT create_hypertable('test_schema.telemetry_raw', 'ts');
 
 \endif
 CREATE MATERIALIZED VIEW test_schema.cagg1
-  WITH (timescaledb.continuous)
+  WITH (timescaledb.continuous, timescaledb.materialized_only=false)
     AS
 SELECT time_bucket(INTERVAL '1s', ts) AS ts_1s,
        avg(value)
   FROM test_schema.telemetry_raw
  GROUP BY ts_1s WITH NO DATA;
 CREATE MATERIALIZED VIEW test_schema.cagg2
-  WITH (timescaledb.continuous)
+  WITH (timescaledb.continuous, timescaledb.materialized_only=false)
     AS
 SELECT time_bucket(INTERVAL '1s', ts) AS ts_1s,
        avg(value)
@@ -1604,13 +1604,13 @@ SELECT table_name FROM create_hypertable('i3696','time');
 (1 row)
 
 \endif
-CREATE MATERIALIZED VIEW i3696_cagg1 WITH (timescaledb.continuous)
+CREATE MATERIALIZED VIEW i3696_cagg1 WITH (timescaledb.continuous, timescaledb.materialized_only=false)
 AS
  SELECT  search_query,count(search_query) as count, sum(cnt), time_bucket(INTERVAL '1 minute', time) AS bucket
  FROM i3696 GROUP BY cnt +cnt2 , bucket, search_query;
 psql:include/cagg_ddl_common.sql:1108: NOTICE:  continuous aggregate "i3696_cagg1" is already up-to-date
 ALTER MATERIALIZED VIEW i3696_cagg1 SET (timescaledb.materialized_only = 'true');
-CREATE MATERIALIZED VIEW i3696_cagg2 WITH (timescaledb.continuous)
+CREATE MATERIALIZED VIEW i3696_cagg2 WITH (timescaledb.continuous, timescaledb.materialized_only=false)
 AS
  SELECT  search_query,count(search_query) as count, sum(cnt), time_bucket(INTERVAL '1 minute', time) AS bucket
  FROM i3696 GROUP BY cnt + cnt2, bucket, search_query
@@ -1630,7 +1630,7 @@ SELECT create_hypertable('test_setting', 'time');
 (1 row)
 
 \endif
-CREATE MATERIALIZED VIEW test_setting_cagg with (timescaledb.continuous)
+CREATE MATERIALIZED VIEW test_setting_cagg with (timescaledb.continuous, timescaledb.materialized_only=false)
 AS SELECT time_bucket('1h',time), avg(val), count(*) FROM test_setting GROUP BY 1;
 psql:include/cagg_ddl_common.sql:1130: NOTICE:  continuous aggregate "test_setting_cagg" is already up-to-date
 INSERT INTO test_setting
@@ -1947,25 +1947,25 @@ SELECT * FROM cashflows;
 -- 4. test named bucket width
 -- named origin
 CREATE MATERIALIZED VIEW cagg_named_origin WITH
-(timescaledb.continuous) AS
+(timescaledb.continuous, timescaledb.materialized_only=false) AS
 SELECT time_bucket('1h', time, 'UTC', origin => '2001-01-03 01:23:45') AS bucket,
 avg(amount) as avg_amount
 FROM transactions GROUP BY 1 WITH NO DATA;
 -- named timezone
 CREATE MATERIALIZED VIEW cagg_named_tz_origin WITH
-(timescaledb.continuous) AS
+(timescaledb.continuous, timescaledb.materialized_only=false) AS
 SELECT time_bucket('1h', time, timezone => 'UTC', origin => '2001-01-03 01:23:45') AS bucket,
 avg(amount) as avg_amount
 FROM transactions GROUP BY 1 WITH NO DATA;
 -- named ts
 CREATE MATERIALIZED VIEW cagg_named_ts_tz_origin WITH
-(timescaledb.continuous) AS
+(timescaledb.continuous, timescaledb.materialized_only=false) AS
 SELECT time_bucket('1h', ts => time, timezone => 'UTC', origin => '2001-01-03 01:23:45') AS bucket,
 avg(amount) as avg_amount
 FROM transactions GROUP BY 1 WITH NO DATA;
 -- named bucket width
 CREATE MATERIALIZED VIEW cagg_named_all WITH
-(timescaledb.continuous) AS
+(timescaledb.continuous, timescaledb.materialized_only=false) AS
 SELECT time_bucket(bucket_width => '1h', ts => time, timezone => 'UTC', origin => '2001-01-03 01:23:45') AS bucket,
 avg(amount) as avg_amount
 FROM transactions GROUP BY 1 WITH NO DATA;
@@ -2015,7 +2015,7 @@ SELECT * FROM transactions_montly ORDER BY bucket;
 
 -- Check set_chunk_time_interval on continuous aggregate
 CREATE MATERIALIZED VIEW cagg_set_chunk_time_interval
-WITH (timescaledb.continuous) AS
+WITH (timescaledb.continuous, timescaledb.materialized_only=false) AS
 SELECT time_bucket(INTERVAL '1 month', time) AS bucket,
        SUM(fiat_value),
        MAX(fiat_value),

diff --git a/tsl/test/expected/cagg_ddl_dist_ht.out b/tsl/test/expected/cagg_ddl_dist_ht.out
@@ -1140,65 +1140,65 @@ FROM (
 (3 rows)
 
 -- width expression for int2 hypertables
-CREATE MATERIALIZED VIEW width_expr WITH (timescaledb.continuous) AS
+CREATE MATERIALIZED VIEW width_expr WITH (timescaledb.continuous, timescaledb.materialized_only=false) AS
 SELECT time_bucket(1::smallint, time)
 FROM metrics_int2
 GROUP BY 1;
 psql:include/cagg_ddl_common.sql:750: NOTICE:  continuous aggregate "width_expr" is already up-to-date
 DROP MATERIALIZED VIEW width_expr;
-CREATE MATERIALIZED VIEW width_expr WITH (timescaledb.continuous) AS
+CREATE MATERIALIZED VIEW width_expr WITH (timescaledb.continuous, timescaledb.materialized_only=false) AS
 SELECT time_bucket(1::smallint + 2::smallint, time)
 FROM metrics_int2
 GROUP BY 1;
 psql:include/cagg_ddl_common.sql:757: NOTICE:  continuous aggregate "width_expr" is already up-to-date
 DROP MATERIALIZED VIEW width_expr;
 -- width expression for int4 hypertables
-CREATE MATERIALIZED VIEW width_expr WITH (timescaledb.continuous) AS
+CREATE MATERIALIZED VIEW width_expr WITH (timescaledb.continuous, timescaledb.materialized_only=false) AS
 SELECT time_bucket(1, time)
 FROM metrics_int4
 GROUP BY 1;
 psql:include/cagg_ddl_common.sql:765: NOTICE:  continuous aggregate "width_expr" is already up-to-date
 DROP MATERIALIZED VIEW width_expr;
-CREATE MATERIALIZED VIEW width_expr WITH (timescaledb.continuous) AS
+CREATE MATERIALIZED VIEW width_expr WITH (timescaledb.continuous, timescaledb.materialized_only=false) AS
 SELECT time_bucket(1 + 2, time)
 FROM metrics_int4
 GROUP BY 1;
 psql:include/cagg_ddl_common.sql:772: NOTICE:  continuous aggregate "width_expr" is already up-to-date
 DROP MATERIALIZED VIEW width_expr;
 -- width expression for int8 hypertables
-CREATE MATERIALIZED VIEW width_expr WITH (timescaledb.continuous) AS
+CREATE MATERIALIZED VIEW width_expr WITH (timescaledb.continuous, timescaledb.materialized_only=false) AS
 SELECT time_bucket(1, time)
 FROM metrics_int8
 GROUP BY 1;
 psql:include/cagg_ddl_common.sql:780: NOTICE:  continuous aggregate "width_expr" is already up-to-date
 DROP MATERIALIZED VIEW width_expr;
-CREATE MATERIALIZED VIEW width_expr WITH (timescaledb.continuous) AS
+CREATE MATERIALIZED VIEW width_expr WITH (timescaledb.continuous, timescaledb.materialized_only=false) AS
 SELECT time_bucket(1 + 2, time)
 FROM metrics_int8
 GROUP BY 1;
 psql:include/cagg_ddl_common.sql:787: NOTICE:  continuous aggregate "width_expr" is already up-to-date
 DROP MATERIALIZED VIEW width_expr;
 \set ON_ERROR_STOP 0
 -- non-immutable expresions should be rejected
-CREATE MATERIALIZED VIEW width_expr WITH (timescaledb.continuous) AS
+CREATE MATERIALIZED VIEW width_expr WITH (timescaledb.continuous, timescaledb.materialized_only=false) AS
 SELECT time_bucket(extract(year FROM now())::smallint, time)
 FROM metrics_int2
 GROUP BY 1;
 psql:include/cagg_ddl_common.sql:796: ERROR:  only immutable expressions allowed in time bucket function
-CREATE MATERIALIZED VIEW width_expr WITH (timescaledb.continuous) AS
+CREATE MATERIALIZED VIEW width_expr WITH (timescaledb.continuous, timescaledb.materialized_only=false) AS
 SELECT time_bucket(extract(year FROM now())::int, time)
 FROM metrics_int4
 GROUP BY 1;
 psql:include/cagg_ddl_common.sql:801: ERROR:  only immutable expressions allowed in time bucket function
-CREATE MATERIALIZED VIEW width_expr WITH (timescaledb.continuous) AS
+CREATE MATERIALIZED VIEW width_expr WITH (timescaledb.continuous, timescaledb.materialized_only=false) AS
 SELECT time_bucket(extract(year FROM now())::int, time)
 FROM metrics_int8
 GROUP BY 1;
 psql:include/cagg_ddl_common.sql:806: ERROR:  only immutable expressions allowed in time bucket function
 \set ON_ERROR_STOP 1
 -- Test various ALTER MATERIALIZED VIEW statements.
 SET ROLE :ROLE_DEFAULT_PERM_USER;
-CREATE MATERIALIZED VIEW owner_check WITH (timescaledb.continuous) AS
+CREATE MATERIALIZED VIEW owner_check WITH (timescaledb.continuous, timescaledb.materialized_only=false) AS
 SELECT time_bucket(1 + 2, time)
 FROM metrics_int8
 GROUP BY 1
@@ -1336,7 +1336,7 @@ SELECT create_distributed_hypertable('test_schema.telemetry_raw', 'ts', replicat
 SELECT create_hypertable('test_schema.telemetry_raw', 'ts');
 \endif
 CREATE MATERIALIZED VIEW test_schema.telemetry_1s
-  WITH (timescaledb.continuous)
+  WITH (timescaledb.continuous, timescaledb.materialized_only=false)
     AS
 SELECT time_bucket(INTERVAL '1s', ts) AS ts_1s,
        avg(value)
@@ -1399,14 +1399,14 @@ SELECT create_distributed_hypertable('test_schema.telemetry_raw', 'ts', replicat
 SELECT create_hypertable('test_schema.telemetry_raw', 'ts');
 \endif
 CREATE MATERIALIZED VIEW test_schema.cagg1
-  WITH (timescaledb.continuous)
+  WITH (timescaledb.continuous, timescaledb.materialized_only=false)
     AS
 SELECT time_bucket(INTERVAL '1s', ts) AS ts_1s,
        avg(value)
   FROM test_schema.telemetry_raw
  GROUP BY ts_1s WITH NO DATA;
 CREATE MATERIALIZED VIEW test_schema.cagg2
-  WITH (timescaledb.continuous)
+  WITH (timescaledb.continuous, timescaledb.materialized_only=false)
     AS
 SELECT time_bucket(INTERVAL '1s', ts) AS ts_1s,
        avg(value)
@@ -1647,13 +1647,13 @@ SELECT create_distributed_hypertable('i3696', 'time', replication_factor => 2);
 \else
 SELECT table_name FROM create_hypertable('i3696','time');
 \endif
-CREATE MATERIALIZED VIEW i3696_cagg1 WITH (timescaledb.continuous)
+CREATE MATERIALIZED VIEW i3696_cagg1 WITH (timescaledb.continuous, timescaledb.materialized_only=false)
 AS
  SELECT  search_query,count(search_query) as count, sum(cnt), time_bucket(INTERVAL '1 minute', time) AS bucket
  FROM i3696 GROUP BY cnt +cnt2 , bucket, search_query;
 psql:include/cagg_ddl_common.sql:1108: NOTICE:  continuous aggregate "i3696_cagg1" is already up-to-date
 ALTER MATERIALIZED VIEW i3696_cagg1 SET (timescaledb.materialized_only = 'true');
-CREATE MATERIALIZED VIEW i3696_cagg2 WITH (timescaledb.continuous)
+CREATE MATERIALIZED VIEW i3696_cagg2 WITH (timescaledb.continuous, timescaledb.materialized_only=false)
 AS
  SELECT  search_query,count(search_query) as count, sum(cnt), time_bucket(INTERVAL '1 minute', time) AS bucket
  FROM i3696 GROUP BY cnt + cnt2, bucket, search_query
@@ -1673,7 +1673,7 @@ SELECT create_distributed_hypertable('test_setting', 'time', replication_factor
 \else
 SELECT create_hypertable('test_setting', 'time');
 \endif
-CREATE MATERIALIZED VIEW test_setting_cagg with (timescaledb.continuous)
+CREATE MATERIALIZED VIEW test_setting_cagg with (timescaledb.continuous, timescaledb.materialized_only=false)
 AS SELECT time_bucket('1h',time), avg(val), count(*) FROM test_setting GROUP BY 1;
 psql:include/cagg_ddl_common.sql:1130: NOTICE:  continuous aggregate "test_setting_cagg" is already up-to-date
 INSERT INTO test_setting
@@ -1990,25 +1990,25 @@ SELECT * FROM cashflows;
 -- 4. test named bucket width
 -- named origin
 CREATE MATERIALIZED VIEW cagg_named_origin WITH
-(timescaledb.continuous) AS
+(timescaledb.continuous, timescaledb.materialized_only=false) AS
 SELECT time_bucket('1h', time, 'UTC', origin => '2001-01-03 01:23:45') AS bucket,
 avg(amount) as avg_amount
 FROM transactions GROUP BY 1 WITH NO DATA;
 -- named timezone
 CREATE MATERIALIZED VIEW cagg_named_tz_origin WITH
-(timescaledb.continuous) AS
+(timescaledb.continuous, timescaledb.materialized_only=false) AS
 SELECT time_bucket('1h', time, timezone => 'UTC', origin => '2001-01-03 01:23:45') AS bucket,
 avg(amount) as avg_amount
 FROM transactions GROUP BY 1 WITH NO DATA;
 -- named ts
 CREATE MATERIALIZED VIEW cagg_named_ts_tz_origin WITH
-(timescaledb.continuous) AS
+(timescaledb.continuous, timescaledb.materialized_only=false) AS
 SELECT time_bucket('1h', ts => time, timezone => 'UTC', origin => '2001-01-03 01:23:45') AS bucket,
 avg(amount) as avg_amount
 FROM transactions GROUP BY 1 WITH NO DATA;
 -- named bucket width
 CREATE MATERIALIZED VIEW cagg_named_all WITH
-(timescaledb.continuous) AS
+(timescaledb.continuous, timescaledb.materialized_only=false) AS
 SELECT time_bucket(bucket_width => '1h', ts => time, timezone => 'UTC', origin => '2001-01-03 01:23:45') AS bucket,
 avg(amount) as avg_amount
 FROM transactions GROUP BY 1 WITH NO DATA;
@@ -2058,7 +2058,7 @@ SELECT * FROM transactions_montly ORDER BY bucket;
 
 -- Check set_chunk_time_interval on continuous aggregate
 CREATE MATERIALIZED VIEW cagg_set_chunk_time_interval
-WITH (timescaledb.continuous) AS
+WITH (timescaledb.continuous, timescaledb.materialized_only=false) AS
 SELECT time_bucket(INTERVAL '1 month', time) AS bucket,
        SUM(fiat_value),
        MAX(fiat_value),

diff --git a/tsl/test/expected/cagg_drop_chunks.out b/tsl/test/expected/cagg_drop_chunks.out
@@ -24,7 +24,7 @@ SELECT * FROM create_hypertable('records', 'time',
 (1 row)
 
 CREATE MATERIALIZED VIEW records_monthly
-    WITH (timescaledb.continuous)
+    WITH (timescaledb.continuous, timescaledb.materialized_only=false)
     AS
         SELECT time_bucket('1d', time) as bucket,
             clientId,