Skip to content

Commit

Permalink
Fix non-deterministic cagg_insert isolation test
Browse files Browse the repository at this point in the history
One permutation of the cagg_insert isolation test contains an assumption
about the execution order of three processes after a lock is released.
However, this behavior is non-deterministic. This PR makes the
assumption explicit and adds proper markers to the isolation test to
make the output deterministic.
  • Loading branch information
jnidzwetzki committed Aug 31, 2023
1 parent 08231c8 commit 77dc6ed
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tsl/test/isolation/specs/cagg_insert.spec
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ step "LockMatInval" { BEGIN; LOCK TABLE _timescaledb_catalog.continuous_aggs_mat
step "UnlockMatInval" { ROLLBACK; }

#only one refresh
permutation "LockInvalThrEx" "Refresh" "Refresh2" "Refresh3" "UnlockInvalThrEx"
permutation "LockInvalThrEx" "Refresh" "Refresh2" (Refresh) "Refresh3" (Refresh, Refresh2) "UnlockInvalThrEx"

#refresh and insert do not block each other once refresh is out of the
#first transaction where it moves the invalidation threshold
Expand Down

0 comments on commit 77dc6ed

Please sign in to comment.