PG16: Reset PlannerInfo->placeholdersFrozen #6168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jnidzwetzki, @erimatnor: please review this pull request.
|
fabriziomello
force-pushed
the
pg16-reset-placeholdersFrozen
branch
from
c8cac0f to
3cdb15a
Compare
Codecov Report
@@ Coverage Diff @@
## main #6168 +/- ##
==========================================
- Coverage 81.44% 81.41% -0.03%
==========================================
Files 246 246
Lines 56974 56928 -46
Branches 12624 12605 -19
==========================================
- Hits 46400 46346 -54
+ Misses 8196 8170 -26
- Partials 2378 2412 +34
... and 45 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
svenklemm
reviewed
Oct 8, 2023
svenklemm
approved these changes
Oct 8, 2023
jnidzwetzki
approved these changes
Oct 8, 2023
Reset the flag to control PlaceHolderInfo creation because we're copying the entire content of the (PlannerInfo *)root data structure when building the first/last path. postgres/postgres@b3ff6c74
fabriziomello
force-pushed
the
pg16-reset-placeholdersFrozen
branch
from
3cdb15a to
226ae43
Compare
fabriziomello
added a commit
to fabriziomello/timescaledb
that referenced
this pull request
Oct 28, 2023
In timescale#6168 we added the ordered append output test for PG16 but unfortunately it was wrong and didn't take in account the planner output differences introduced. Fixed it by changing properly the output changes for PG16.
fabriziomello
added a commit
to fabriziomello/timescaledb
that referenced
this pull request
Oct 28, 2023
In timescale#6168 we added the ordered append output test for PG16 but unfortunately it was wrong and didn't take in account the planner output differences introduced. Fixed it by changing properly the output changes for PG16.
fabriziomello
added a commit
that referenced
this pull request
Oct 28, 2023
In #6168 we added the ordered append output test for PG16 but unfortunately it was wrong and didn't take in account the planner output differences introduced. Fixed it by changing properly the output changes for PG16.
jnidzwetzki
pushed a commit
to jnidzwetzki/timescaledb
that referenced
this pull request
Nov 9, 2023
In timescale#6168 we added the ordered append output test for PG16 but unfortunately it was wrong and didn't take in account the planner output differences introduced. Fixed it by changing properly the output changes for PG16.
jnidzwetzki
pushed a commit
to jnidzwetzki/timescaledb
that referenced
this pull request
Nov 19, 2023
In timescale#6168 we added the ordered append output test for PG16 but unfortunately it was wrong and didn't take in account the planner output differences introduced. Fixed it by changing properly the output changes for PG16.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reset the flag to control PlaceHolderInfo creation because we're copying the entire content of the (PlannerInfo *)root data structure when building the first/last path.
postgres/postgres@b3ff6c74
Disable-check: force-changelog-file