PG16: Fix ordered append output test #6245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In timescale#6168 we added the ordered append output test for PG16 but unfortunately it was wrong and didn't take in account the planner output differences introduced. Fixed it by changing properly the output changes for PG16.
|
@gayyappan, @akuzm: please review this pull request.
|
fabriziomello
force-pushed
the
pg16-fix-ordered-append-output-test
branch
from
251f5a8 to
40bb52e
Compare
svenklemm
approved these changes
Oct 28, 2023
Codecov Report
@@ Coverage Diff @@
## main #6245 +/- ##
==========================================
- Coverage 65.12% 65.09% -0.03%
==========================================
Files 246 246
Lines 57064 57018 -46
Branches 12651 12632 -19
==========================================
- Hits 37161 37118 -43
- Misses 18024 18025 +1
+ Partials 1879 1875 -4 see 16 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jnidzwetzki
approved these changes
Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #6168 we added the ordered append output test for PG16 but unfortunately it was wrong and didn't take in account the planner output differences introduced.
Fixed it by changing properly the output changes for PG16.
Disable-check: force-changelog-file