Fix race condition when creating CAgg #6001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #6001 +/- ##
==========================================
- Coverage 81.53% 81.53% -0.01%
==========================================
Files 246 246
Lines 56581 56539 -42
Branches 12537 12519 -18
==========================================
- Hits 46135 46099 -36
+ Misses 8085 8051 -34
- Partials 2361 2389 +28
... and 45 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
fabriziomello
force-pushed
the
fix_race_condition_when_adding_cagg_trigger
branch
from
adcc62f to
7b2390f
Compare
fabriziomello
force-pushed
the
fix_race_condition_when_adding_cagg_trigger
branch
2 times, most recently
from
307913b to
60b6a27
Compare
mkindahl
reviewed
Sep 1, 2023
fabriziomello
force-pushed
the
fix_race_condition_when_adding_cagg_trigger
branch
from
60b6a27 to
2a5a970
Compare
Done! |
|
@svenklemm, @mahipv: please review this pull request.
|
fabriziomello
force-pushed
the
fix_race_condition_when_adding_cagg_trigger
branch
2 times, most recently
from
6a43979 to
4c986d3
Compare
akuzm
approved these changes
Sep 12, 2023
mkindahl
approved these changes
Sep 12, 2023
fabriziomello
force-pushed
the
fix_race_condition_when_adding_cagg_trigger
branch
from
4c986d3 to
3b2e592
Compare
fabriziomello
added
the
disable-auto-backport
fabriziomello
force-pushed
the
fix_race_condition_when_adding_cagg_trigger
branch
from
3b2e592 to
0a4b43c
Compare
Creating one or more Continuous Aggregates over the same hypertable concurrently in different sessions lead to a race condition on checking for the existance of the trigger `ts_cagg_invalidation_trigger`. Fixed it by using the `OR REPLACE` option for the `CREATE TRIGGER` statement introduced in PG14 and for prior versions taking an `ShareUpdateExclusiveLock` and holding it until the end of the transaction when checking the trigger existance in the `check_trigger_exists_hypertable` function.
fabriziomello
force-pushed
the
fix_race_condition_when_adding_cagg_trigger
branch
from
0a4b43c to
3f4ccd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating one or more Continuous Aggregates over the same hypertable
concurrently in different sessions lead to a race condition on checking
for the existance of the trigger
ts_cagg_invalidation_trigger.Fixed it by using the
OR REPLACEoption for theCREATE TRIGGERstatement introduced in PG14 and for prior versions taking an
ShareUpdateExclusiveLockand holding it until the end of thetransaction when checking the trigger existance in the
check_trigger_exists_hypertablefunction.Disable-check: force-changelog-file