Make multinode tests conditional #6026
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6026 +/- ##
==========================================
- Coverage 87.13% 81.18% -5.95%
==========================================
Files 243 243
Lines 55970 55923 -47
Branches 12397 12378 -19
==========================================
- Hits 48767 45402 -3365
- Misses 4862 8169 +3307
- Partials 2341 2352 +11 see 98 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
svenklemm
force-pushed
the
multinode_conditional
branch
2 times, most recently
from
eb5490c to
7a2d4db
Compare
Since multinode tests take a long time to run we dont want to run them in CI on individual PRs but only on nightly runs.
svenklemm
force-pushed
the
multinode_conditional
branch
from
7a2d4db to
e80b3c2
Compare
|
@jnidzwetzki, @mahipv: please review this pull request.
|
| deadlock_drop_chunks_compress.spec) | ||
|
|
||
| if(ENABLE_MULTINODE_TESTS) |
There was a problem hiding this comment.
Should it also check for DEBUG builds only here and below?
if (ENABLE_MULTINODE_TESTS AND CMAKE_BUILD_TYPE MATCHES Debug) ...
Or maybe invalidate ENABLE_MULTINODE_TESTS globally if not in DEBUG build
There was a problem hiding this comment.
This test didnt require DEBUG previously and the tests below are nested in a DEBUG check
There was a problem hiding this comment.
Not all multinode tests require DEBUG and I kept these requirements intact.
Since multinode tests take a long time to run we dont want to run them in CI on individual PRs but only on nightly runs.
Disable-check: force-changelog-file