Fix an invalid SPI result use after free #6029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pmwkaa, @konskov: please review this pull request.
|
This PR fixes the invalid use of an SPI result after SPI_finish is called and the result is freed.
jnidzwetzki
force-pushed
the
fix_use_after_free
branch
from
09f7340 to
7ca37e5
Compare
Codecov Report
@@ Coverage Diff @@
## main #6029 +/- ##
==========================================
- Coverage 87.14% 81.23% -5.91%
==========================================
Files 243 243
Lines 55969 55925 -44
Branches 12397 12378 -19
==========================================
- Hits 48775 45433 -3342
- Misses 4856 8161 +3305
+ Partials 2338 2331 -7
... and 85 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
svenklemm
approved these changes
Aug 30, 2023
mkindahl
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the invalid use of an SPI result after SPI_finish is called and the result is freed.
Disable-check: force-changelog-file