Restrict creation of partial cagg #6056
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #6056 +/- ##
==========================================
- Coverage 81.43% 73.64% -7.79%
==========================================
Files 243 243
Lines 55948 49083 -6865
Branches 12389 12285 -104
==========================================
- Hits 45562 36148 -9414
+ Misses 8048 7197 -851
- Partials 2338 5738 +3400
... and 220 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pdipesh02
force-pushed
the
ts_old_cagg_2
branch
2 times, most recently
from
370648c to
1935d26
Compare
Block creation of old format cagg. However, partial aggregates can be created under a custom boolean variable `block_old_format_cagg`. This variable can be used only for development purposes like validating migration from old format to new format cagg until we completely remove the old format cagg.
pdipesh02
force-pushed
the
ts_old_cagg_2
branch
from
1935d26 to
e5d4438
Compare
|
On other PRs we will continue this effort. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Block creation of old format cagg. However, partial aggregates can be created under a custom boolean variable
block_old_format_cagg. This variable can be used only for development purposes like validating migration from old format to new format cagg until we completely remove the old format cagg.