-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ubuntu kinetic from package test since it's EOL #6080
Conversation
@akuzm, @jnidzwetzki: please review this pull request.
|
Codecov Report
@@ Coverage Diff @@
## main #6080 +/- ##
==========================================
- Coverage 81.53% 81.49% -0.05%
==========================================
Files 246 246
Lines 56579 56662 +83
Branches 12535 12552 +17
==========================================
+ Hits 46134 46179 +45
- Misses 8067 8081 +14
- Partials 2378 2402 +24 see 28 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
.github/workflows/apt-packages.yaml
Outdated
@@ -4,6 +4,7 @@ name: APT packages | |||
schedule: | |||
# run daily 0:00 on main branch | |||
- cron: '0 0 * * *' | |||
pull_request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious why we're adding this trigger and now testing packages on every PR. Could you elaborate on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just for testing the workflow, i'll remove that line before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm adding trigger by workflow path in every workflow I'm changing, very convenient: https://github.com/timescale/timescaledb/blob/main/.github/workflows/sanitizer-build-and-test.yaml#L13
352d50f
to
6de1a9d
Compare
Disable-check: force-changelog-file