Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ubuntu kinetic from package test since it's EOL #6080

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

svenklemm
Copy link
Member

@svenklemm svenklemm commented Sep 16, 2023

Disable-check: force-changelog-file

@github-actions
Copy link

@akuzm, @jnidzwetzki: please review this pull request.

Powered by pull-review

@svenklemm svenklemm requested review from konskov, jnidzwetzki, akuzm and pallavisontakke and removed request for jnidzwetzki and akuzm September 16, 2023 08:55
@svenklemm svenklemm added this to the TimescaleDB 2.12 milestone Sep 16, 2023
@codecov
Copy link

codecov bot commented Sep 16, 2023

Codecov Report

Merging #6080 (6de1a9d) into main (98507d4) will decrease coverage by 0.05%.
Report is 4 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #6080      +/-   ##
==========================================
- Coverage   81.53%   81.49%   -0.05%     
==========================================
  Files         246      246              
  Lines       56579    56662      +83     
  Branches    12535    12552      +17     
==========================================
+ Hits        46134    46179      +45     
- Misses       8067     8081      +14     
- Partials     2378     2402      +24     

see 28 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@@ -4,6 +4,7 @@ name: APT packages
schedule:
# run daily 0:00 on main branch
- cron: '0 0 * * *'
pull_request:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious why we're adding this trigger and now testing packages on every PR. Could you elaborate on this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just for testing the workflow, i'll remove that line before merging.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm adding trigger by workflow path in every workflow I'm changing, very convenient: https://github.com/timescale/timescaledb/blob/main/.github/workflows/sanitizer-build-and-test.yaml#L13

@svenklemm svenklemm enabled auto-merge (rebase) September 17, 2023 15:06
@svenklemm svenklemm merged commit 24e4972 into timescale:main Sep 18, 2023
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants