Fix flaky compression_update_delete test #6085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The compression_update_delete test sets the log level to DEBUG1. Especially on Windows, the additional log message 'DEBUG: compacted fsync request queue from XXX entries to XXX entries' causes the test to be flaky. This patch removes this log message from the test output.
Codecov Report
@@ Coverage Diff @@
## main #6085 +/- ##
==========================================
+ Coverage 74.01% 81.41% +7.39%
==========================================
Files 246 246
Lines 49701 56662 +6961
Branches 12478 12552 +74
==========================================
+ Hits 36788 46131 +9343
- Misses 7097 8107 +1010
+ Partials 5816 2424 -3392 see 227 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@mahipv, @svenklemm: please review this pull request.
|
|
I think the real fix would be to not use DEBUG1 as this seems just a bandaid. |
svenklemm
approved these changes
Sep 18, 2023
fabriziomello
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compression_update_delete test (and further tests) sets the log level to DEBUG1. Especially on Windows, the additional log message 'DEBUG: compacted fsync request queue from XXX entries to XXX entries' causes the test to be flaky. This patch removes this log message from the test output.
Fixes: #4723
Disable-check: force-changelog-file
Link to failed CI run: https://github.com/timescale/timescaledb/actions/runs/6215855526/job/16869164441