Fix error in osmcallback hook #6106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #6106 +/- ##
==========================================
- Coverage 81.52% 81.47% -0.06%
==========================================
Files 246 246
Lines 56777 56731 -46
Branches 12588 12569 -19
==========================================
- Hits 46288 46221 -67
+ Misses 8103 8099 -4
- Partials 2386 2411 +25
... and 45 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@akuzm, @mahipv: please review this pull request.
|
gayyappan
requested review from
zilder
and removed request for
akuzm and
mahipv
zilder
approved these changes
Sep 22, 2023
The callback hook should use the old pointer instead of the new. This causes a segfault when ptr is NULL.
|
@gayyappan Is it possible to trigger this bug reliably (i.e., could you provide a test case?) |
konskov
approved these changes
Sep 22, 2023
fabriziomello
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The callback hook should use the old pointer instead of the new. This causes a segfault when ptr is NULL.