Ensure database is unused in bgw_launcher test #6109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bgw_launcher test changes the tablespace for a database. However, this requires that the database is used and no BGW are accessing the database. This PR ensures that the background workers are stopped before the tablespace is changed.
jnidzwetzki
force-pushed
the
fix_bgw_launcher_test
branch
from
84aef9d to
055837f
Compare
Codecov Report
@@ Coverage Diff @@
## main #6109 +/- ##
==========================================
- Coverage 81.52% 81.47% -0.06%
==========================================
Files 246 246
Lines 56773 56727 -46
Branches 12587 12568 -19
==========================================
- Hits 46287 46221 -66
+ Misses 8102 8096 -6
- Partials 2384 2410 +26 see 44 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@mkindahl, @fabriziomello: please review this pull request.
|
fabriziomello
approved these changes
Sep 22, 2023
antekresic
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bgw_launcher test changes the tablespace for a database. However, this requires that the database is used and no BGW are accessing the database. This PR ensures that the background workers are stopped before the tablespace is changed.
Disable-check: force-changelog-file
Failing CI run: https://github.com/timescale/timescaledb/actions/runs/6268372126/job/17023181691