Fix assert in dimension slice lookup #6112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jnidzwetzki, @mkindahl: please review this pull request.
|
Codecov Report
@@ Coverage Diff @@
## main #6112 +/- ##
==========================================
- Coverage 81.53% 81.52% -0.02%
==========================================
Files 246 246
Lines 56777 56735 -42
Branches 12588 12569 -19
==========================================
- Hits 46295 46253 -42
+ Misses 8100 8071 -29
- Partials 2382 2411 +29
... and 42 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
svenklemm
force-pushed
the
osm_crash
branch
2 times, most recently
from
f332495 to
522b8ef
Compare
konskov
approved these changes
Sep 25, 2023
Calling ts_scan_iterator_next will advance internal scanner data structures. It is therefore not safe to use the iterator after ts_scan_iterator_next returned NULL and expect to be able to access the previous tuple. Under certain circumstances this may point the iterator to tuples not normally visible.
svenklemm
force-pushed
the
osm_crash
branch
from
522b8ef to
0a5a49f
Compare
erimatnor
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling ts_scan_iterator_next will advance internal scanner data structures. It is therefore not safe to use the iterator after ts_scan_iterator_next returned NULL and expect to be able to access the previous tuple. Under certain circumstances this may point the iterator to tuples not normally visible.
Disable-check: force-changelog-file