Backport to 2.12.x: #6113: Fix planner distributed table count #6120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check for a distributed hypertable was done after ht had been changed to the compressed hypertable potentially leading to miscount or even segfault when the cache lookup for the compressed hypertable returned NULL. (cherry picked from commit 727a027)
timescale-automation
added
the
is-auto-backport
Codecov Report
@@ Coverage Diff @@
## 2.12.x #6120 +/- ##
==========================================
- Coverage 81.51% 81.47% -0.04%
==========================================
Files 246 246
Lines 56781 56734 -47
Branches 12588 12568 -20
==========================================
- Hits 46284 46225 -59
+ Misses 8115 8097 -18
- Partials 2382 2412 +30
... and 46 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated backport of #6113: Fix planner distributed table count.
The original issue is #5966.
This PR will be merged automatically after all the relevant CI checks pass. If this fix should not be backported, or will be backported manually, just close this PR. You can use the backport branch to add your changes, it won't be modified automatically anymore.
For more details, please see the documentation
Original description
Fix planner distributed table count
The check for a distributed hypertable was done after ht had been changed to the compressed hypertable potentially leading to miscount or even segfault when the cache lookup for the compressed hypertable returned NULL.
Fixes#5966