Remove multinode tests from regresscheck-shared #6156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The multinode tests in regresscheck-shared were already disabled by default and removing them allows us to skip setting up the multinode environment in regresscheck-shared. This database is also used for sqlsmith which will make sqlsmith runs more targetted. Additionally this will be a step towards running regresscheck-shared unmodified against our cloud.
|
@jnidzwetzki, @mkindahl: please review this pull request.
|
Codecov Report
@@ Coverage Diff @@
## main #6156 +/- ##
==========================================
+ Coverage 74.06% 81.41% +7.35%
==========================================
Files 246 246
Lines 50023 56928 +6905
Branches 12563 12605 +42
==========================================
+ Hits 37050 46349 +9299
- Misses 7111 8190 +1079
+ Partials 5862 2389 -3473 see 227 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
fabriziomello
approved these changes
Oct 5, 2023
|
@svenklemm This may be beyond the scope of this PR. But have you considered removing |
jnidzwetzki
approved these changes
Oct 5, 2023
Definitely not in scope of this PR. Are they causing problems there? I'm not opposed to skipping them there if they are flaky. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The multinode tests in regresscheck-shared were already disabled by default and removing them allows us to skip setting up the multinode environment in regresscheck-shared. This database is also used for sqlsmith which will make sqlsmith runs more targetted. Additionally this will be a step towards running regresscheck-shared unmodified against our cloud.
Disable-check: force-changelog-file