Backport to 2.12.x: #6160: Improve arg handling in continuous_agg_trigfn #6162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When continuous_agg_invalidation_trigger is called without any argument, fcinfo->context in continuous_agg_trigfn is NULL and it should not be dereferenced. (cherry picked from commit b514d05)
Codecov Report
@@ Coverage Diff @@
## 2.12.x #6162 +/- ##
=========================================
Coverage ? 81.53%
=========================================
Files ? 246
Lines ? 56771
Branches ? 12576
=========================================
Hits ? 46290
Misses ? 8077
Partials ? 2404 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated backport of #6160: Improve arg handling in continuous_agg_trigfn.
This PR will be merged automatically after all the relevant CI checks pass. If this fix should not be backported, or will be backported manually, just close this PR. You can use the backport branch to add your changes, it won't be modified automatically anymore.
For more details, please see the documentation
Original description
Improve arg handling in continuous_agg_trigfn
When
continuous_agg_invalidation_triggeris called without any argument, fcinfo->context in continuous_agg_trigfn is NULL and it should not be dereferenced.Disable-check: force-changelog-file