Move explain utility functions to src/import #6171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@akuzm, @mahipv: please review this pull request.
|
svenklemm
force-pushed
the
move_explain_utils
branch
from
5d51523 to
b3f7c9b
Compare
Codecov Report
@@ Coverage Diff @@
## main #6171 +/- ##
==========================================
- Coverage 81.44% 81.38% -0.06%
==========================================
Files 246 246
Lines 56974 56928 -46
Branches 12624 12605 -19
==========================================
- Hits 46400 46333 -67
- Misses 8196 8204 +8
- Partials 2378 2391 +13
... and 21 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
src/import/ts_explain.c
Outdated
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * This file and its contents are licensed under the Timescale License. | |||
| * This file and its contents are licensed under the Timescale License. | |||
fabriziomello
approved these changes
Oct 8, 2023
svenklemm
force-pushed
the
move_explain_utils
branch
from
b3f7c9b to
7df4ed9
Compare
This moves EXPLAIN utility functions into apache to make it available to all custom nodes. Since these are copies of static postgres functions there is no reason for them to be TSL licensed.
svenklemm
force-pushed
the
move_explain_utils
branch
from
7df4ed9 to
8e2df62
Compare
jnidzwetzki
approved these changes
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves EXPLAIN utility functions into apache to make it available to all custom nodes. Since these are copies of static postgres functions there is no reason for them to be TSL licensed.
Disable-check: force-changelog-file