Ensure fixed_schedule field is populated #6181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The jobs framework contains two functions for loading jobs (ts_bgw_job_get_scheduled and bgw_job_from_tupleinfo). However, the ts_bgw_job_get_scheduled function did not properly populate the fixed_schedule field, which caused some bugs in the calculation of the next execution time for a job. This PR ensures the fixed_schedule field is populated properly.
jnidzwetzki
commented
Oct 10, 2023
| @@ -377,7 +377,7 @@ ts_bgw_job_get_scheduled(size_t alloc_size, MemoryContext mctx) | |||
| * handle them below. We can only use memcpy for the non-nullable fixed | |||
| * width starting part of the BgwJob struct. | |||
| */ | |||
| memcpy(job, GETSTRUCT(tuple), offsetof(FormData_bgw_job, fixed_schedule)); | |||
| memcpy(job, GETSTRUCT(tuple), offsetof(FormData_bgw_job, initial_start)); | |||
There was a problem hiding this comment.
The fixed_schedule field is now included and all fields starting from initial_start are initialized below.
jnidzwetzki
commented
Oct 10, 2023
| /* handle NULL columns */ | ||
| value = slot_getattr(ti->slot, Anum_bgw_job_hypertable_id, &isnull); |
There was a problem hiding this comment.
Reordered the initialization order to match the order of the FormData_bgw_job struct.
Codecov Report
@@ Coverage Diff @@
## main #6181 +/- ##
==========================================
- Coverage 81.44% 73.78% -7.67%
==========================================
Files 246 246
Lines 56974 49821 -7153
Branches 12624 12505 -119
==========================================
- Hits 46400 36758 -9642
+ Misses 8196 7231 -965
- Partials 2378 5832 +3454
... and 227 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@erimatnor, @antekresic: please review this pull request.
|
konskov
approved these changes
Oct 12, 2023
svenklemm
approved these changes
Oct 12, 2023
svenklemm
added a commit
to svenklemm/timescaledb
that referenced
this pull request
Oct 19, 2023
This release contains bug fixes since the 2.12.1 release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * timescale#6155 Align gapfill bucket generation with time_bucket * timescale#6181 Ensure fixed_schedule field is populated * timescale#6210 Fix EXPLAIN ANALYZE for compressed DML
Merged
svenklemm
added a commit
to svenklemm/timescaledb
that referenced
this pull request
Oct 19, 2023
This release contains bug fixes since the 2.12.1 release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * timescale#6155 Align gapfill bucket generation with time_bucket * timescale#6181 Ensure fixed_schedule field is populated * timescale#6210 Fix EXPLAIN ANALYZE for compressed DML
Merged
jnidzwetzki
pushed a commit
to jnidzwetzki/timescaledb
that referenced
this pull request
Nov 9, 2023
This release contains bug fixes since the 2.12.1 release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * timescale#6155 Align gapfill bucket generation with time_bucket * timescale#6181 Ensure fixed_schedule field is populated * timescale#6210 Fix EXPLAIN ANALYZE for compressed DML
jnidzwetzki
pushed a commit
to jnidzwetzki/timescaledb
that referenced
this pull request
Nov 19, 2023
This release contains bug fixes since the 2.12.1 release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * timescale#6155 Align gapfill bucket generation with time_bucket * timescale#6181 Ensure fixed_schedule field is populated * timescale#6210 Fix EXPLAIN ANALYZE for compressed DML
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The jobs framework contains two functions for loading jobs (ts_bgw_job_get_scheduled and bgw_job_from_tupleinfo). However, the ts_bgw_job_get_scheduled function did not properly populate the
fixed_schedulefield, which caused some bugs in the calculation of the next execution time for a job. This PR ensures the fixed_schedule field is populated properly.We have some checks in
bgw_db_scheduler_fixedto test this code path. However, these tests use our mock framework and trigger only thets_bgw_job_entrypoint -> ts_bgw_job_stat_mark_end -> [..] -> ts_scanner_scan -> bgw_job_from_tupleinfocode path for loading jobs and calculate the next execution for a failed job. Since the second code path can not be tested well at the moment, I did not add test cases and created the follow-up issue https://github.com/timescale/eng-database/issues/535 instead.Disable-check: force-changelog-file