Keep track of catalog version

[svenklemm]

This patch stores the current catalog version in an internal table to allow us to verify catalog and code version match. When doing dump/restore people occasionally report very unusual errors and during investigation it is discovered that they loaded a dump from an older version and run it with a later code version. This allows to detect mismatches between installed code version and loaded dump version. The version number in the metadata table will be kept updated in upgrade and downgrade scripts.

[github-actions]

@mahipv, @konskov: please review this pull request.

Powered by pull-review

[fabriziomello]

Suggested change

	DO $$
	DECLARE
	catalog_version TEXT;
	BEGIN
	IF EXISTS(SELECT FROM _timescaledb_catalog.metadata WHERE key='timescaledb_version' AND value <> '@UPDATE_FROM_VERSION@') THEN
	SELECT value INTO catalog_version FROM _timescaledb_catalog.metadata WHERE key='timescaledb_version';
	RAISE EXCEPTION 'catalog version mismatch, expected "%" seen "%"', '@UPDATE_FROM_VERSION@', catalog_version;
	END IF;
	END$$;
	DO $$
	DECLARE
	catalog_version TEXT;
	BEGIN
	SELECT value INTO catalog_version FROM _timescaledb_catalog.metadata WHERE key='timescaledb_version' AND value <> '@UPDATE_FROM_VERSION@';
	IF FOUND THEN
	RAISE EXCEPTION 'catalog version mismatch, expected "%" seen "%"', '@UPDATE_FROM_VERSION@', catalog_version;
	END IF;
	END$$;

Don't need two SELECT queries over the same metadata table.

[fabriziomello]

Suggested change

	INSERT INTO _timescaledb_catalog.metadata
	SELECT 'timescaledb_version', '@PROJECT_VERSION_MOD@', FALSE ON CONFLICT (key) DO UPDATE SET value = excluded.VALUE;
	INSERT INTO _timescaledb_catalog.metadata (key, value, include_in_telemetry)
	VALUES ('timescaledb_version', '@PROJECT_VERSION_MOD@', FALSE)
	ON CONFLICT (key) DO UPDATE SET value = excluded.VALUE;

[fabriziomello]

Left some cosmetic adjustments but it is up to you! Approved anyway!

[codecov]

Codecov Report

Merging #6185 (df9b387) into main (332bbdb) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #6185      +/-   ##
==========================================
- Coverage   81.45%   81.42%   -0.04%     
==========================================
  Files         246      246              
  Lines       56978    56932      -46     
  Branches    12626    12607      -19     
==========================================
- Hits        46413    46358      -55     
+ Misses       8180     8179       -1     
- Partials     2385     2395      +10     

see 19 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more