Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some code related to pre 1.0 triggers #6187

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

svenklemm
Copy link
Member

@svenklemm svenklemm commented Oct 12, 2023

This code is no longer needed as no valid source timescaledb version in upgrade path can have those legacy triggers.

Disable-check: force-changelog-file

@github-actions
Copy link

@akuzm, @erimatnor: please review this pull request.

Powered by pull-review

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #6187 (253d437) into main (6304c7a) will decrease coverage by 0.04%.
Report is 7 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #6187      +/-   ##
==========================================
- Coverage   81.44%   81.40%   -0.04%     
==========================================
  Files         246      246              
  Lines       56974    56908      -66     
  Branches    12624    12600      -24     
==========================================
- Hits        46400    46327      -73     
+ Misses       8196     8168      -28     
- Partials     2378     2413      +35     
Files Coverage Δ
src/hypertable.c 87.12% <ø> (+1.52%) ⬆️

... and 50 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

This code is no longer needed as no valid source timescaledb version
in upgrade path can have those legacy triggers.
@svenklemm svenklemm requested a review from konskov October 12, 2023 16:23
@svenklemm svenklemm enabled auto-merge (rebase) October 12, 2023 17:35
@svenklemm svenklemm merged commit ecd88f8 into timescale:main Oct 12, 2023
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants