Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PG16: Fix ts_bgw_log_level bootval #6207

Merged

Conversation

fabriziomello
Copy link
Contributor

@fabriziomello fabriziomello commented Oct 17, 2023

When defining a GUC Postgres do a cross-check between the initial value of the C declaration associated to a GUC and its actual boot value in assert-enabled builds.

Previous PR #6206 didn't fixed it entirely and this happen just on PG16.

postgres/postgres@a73952b7

Disable-check: force-changelog-file

When defining a GUC Postgres do a cross-check between the initial value
of the C declaration associated to a GUC and its actual boot value in
assert-enabled builds.

Previous PR timescale#6206 didn't fixed it entirely and this happen just on PG16.

postgres/postgres@a73952b7
@fabriziomello fabriziomello added the pg16 Issue/PR related to support for PG16 label Oct 17, 2023
@fabriziomello fabriziomello self-assigned this Oct 17, 2023
@github-actions
Copy link

@jnidzwetzki, @antekresic: please review this pull request.

Powered by pull-review

@fabriziomello fabriziomello enabled auto-merge (rebase) October 17, 2023 18:47
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #6207 (3a48c5f) into main (4e06cd3) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #6207      +/-   ##
==========================================
- Coverage   81.46%   81.45%   -0.02%     
==========================================
  Files         246      246              
  Lines       56988    56941      -47     
  Branches    12630    12611      -19     
==========================================
- Hits        46428    46382      -46     
+ Misses       8180     8166      -14     
- Partials     2380     2393      +13     
Files Coverage Δ
src/guc.c 96.73% <ø> (-0.04%) ⬇️

... and 23 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fabriziomello fabriziomello merged commit 5f5f519 into timescale:main Oct 17, 2023
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pg16 Issue/PR related to support for PG16
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants