Skip expression columns when verifying index for compression #6209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When enabling compression on a hypertable, we check the unique indexes defined on it to provide performance improvement hints in case the unique index columns are not specified as segmentby columns as well. However this check threw an error when expression columns were present in the index, preventing the user from enabling compression. This patch fixes this by simply ignoring the expression columns in the index, since we cannot currently segment by an expression. Fixes timescale#6205
konskov
force-pushed
the
fix_expression_idx_handling
branch
from
2634bc4 to
ef3ad47
Compare
Codecov Report
@@ Coverage Diff @@
## main #6209 +/- ##
==========================================
- Coverage 81.47% 81.44% -0.03%
==========================================
Files 246 246
Lines 56985 56941 -44
Branches 12629 12611 -18
==========================================
- Hits 46426 46378 -48
+ Misses 8176 8155 -21
- Partials 2383 2408 +25
... and 46 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6205