Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PG16: Removed ignore feature from pg_regress #6228

Conversation

fabriziomello
Copy link
Contributor

@fabriziomello fabriziomello commented Oct 24, 2023

PG16 removed the ignore feature from pg_regress so as an workaround if we have any IGNORES entry then we merge it altogether with SKIPS and cleanup the IGNORES in pg_regress.sh wrapper.

postgres/postgres@bd8d453e

Disable-check: force-changelog-file

@fabriziomello fabriziomello added the pg16 Issue/PR related to support for PG16 label Oct 24, 2023
@fabriziomello fabriziomello self-assigned this Oct 24, 2023
@github-actions github-actions bot requested review from akuzm and konskov October 24, 2023 15:14
@github-actions
Copy link

@konskov, @akuzm: please review this pull request.

Powered by pull-review

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #6228 (5d7de3a) into main (dc91938) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #6228   +/-   ##
=======================================
  Coverage   65.08%   65.08%           
=======================================
  Files         246      246           
  Lines       56973    56973           
  Branches    12623    12623           
=======================================
+ Hits        37079    37081    +2     
- Misses      18016    18017    +1     
+ Partials     1878     1875    -3     

see 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

PG16 removed the `ignore` feature from `pg_regress` so as an workaround
if we have any IGNORES entry then we merge it altogether with SKIPS and
cleanup the IGNORES in `pg_regress.sh` wrapper.

postgres/postgres@bd8d453e
@fabriziomello fabriziomello force-pushed the pg16-removed-ignore-tests-from-pg-regress branch from 44c0809 to 5d7de3a Compare October 24, 2023 19:12
@fabriziomello fabriziomello enabled auto-merge (rebase) October 24, 2023 21:28
@fabriziomello fabriziomello merged commit d614f44 into timescale:main Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pg16 Issue/PR related to support for PG16
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants