Backport to 2.12.x: #6231: Fix flaky upgrade test #6232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upgrade test utilizes several CAggs and defines refresh policies. However, the test results are not deterministic due to the unpredictable timing of the refreshes. This causes the test to be flaky. This pull request explicitly adds explicit refreshes to the upgrade test to ensure that the test results are deterministic. (cherry picked from commit 53e9747)
timescale-automation
added
the
is-auto-backport
Codecov Report
@@ Coverage Diff @@
## 2.12.x #6232 +/- ##
==========================================
- Coverage 81.55% 81.53% -0.03%
==========================================
Files 246 246
Lines 56824 56778 -46
Branches 12597 12578 -19
==========================================
- Hits 46344 46292 -52
+ Misses 8108 8087 -21
- Partials 2372 2399 +27 see 46 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated backport of #6231: Fix flaky upgrade test.
This PR will be merged automatically after all the relevant CI checks pass. If this fix should not be backported, or will be backported manually, just close this PR. You can use the backport branch to add your changes, it won't be modified automatically anymore.
For more details, please see the documentation
Original description
Fix flaky upgrade test
The upgrade test utilizes several CAggs and defines refresh policies.
However, the test results are not deterministic due to the unpredictable
timing of the refreshes. This causes the test to be flaky. This pull
request explicitly adds explicit refreshes to the upgrade test to ensure
that the test results are deterministic.
Link to failed CI run: https://github.com/timescale/timescaledb/actions/runs/6644016971/job/18057621681?pr=6229
Link to fixed CI run: https://github.com/timescale/timescaledb/actions/runs/6646121959/job/18058928349
Disable-check: force-changelog-file