PG16: Refactored ownercheck functions #6242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In our code we have an Event Trigger on `ddl_command_end` to process some DDL commands, and specially the `ALTER TABLE` we execute some code to properly deal with hypertables, chunks and compressed chunks. The problem is when we start to process our code at `ddl_command_end` event we get the related `relid` by calling the `AlterTableLookupRelation` that perform the proper acl checking. But this is a bit wrong because in case of a `ALTER TABLE ... OWNER TO ...` at this point (aka `ddl_command_end`) the ownership of the relation was already processed and with this PG16 refactoring it now is visible for the `object_ownercheck` leading to a misbehavior. Due to our intention is just the get the `relid` related to the AlterTableCmd just fixed it by replacing the `AlterTableLookupRelation` for the `RangeVarGetRelid` because at this point all the proper aclcheck was already done. postgres/postgres@afbfc029
|
@antekresic, @akuzm: please review this pull request.
|
svenklemm
approved these changes
Oct 27, 2023
Codecov Report
@@ Coverage Diff @@
## main #6242 +/- ##
==========================================
- Coverage 65.10% 65.08% -0.03%
==========================================
Files 246 246
Lines 57066 57020 -46
Branches 12651 12632 -19
==========================================
- Hits 37151 37109 -42
- Misses 18046 18058 +12
+ Partials 1869 1853 -16
... and 64 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jnidzwetzki
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our code we have an Event Trigger on
ddl_command_endto process some DDL commands, and specially theALTER TABLEwe execute some code to properly deal with hypertables, chunks and compressed chunks.The problem is when we start to process our code at
ddl_command_endevent we get the relatedrelidby calling theAlterTableLookupRelationthat perform the proper acl checking. But this is a bit wrong because in case of aALTER TABLE ... OWNER TO ...at this point (akaddl_command_end) the ownership of the relation was already processed and with this PG16 refactoring it now is visible for theobject_ownercheckleading to a misbehavior.Due to our intention is just the get the
relidrelated to the AlterTableCmd just fixed it by replacing theAlterTableLookupRelationfor theRangeVarGetRelidbecause at this point all the proper aclcheck was already done.postgres/postgres@afbfc029
Disable-check: force-changelog-file