Determine data type of vector agg at plan stage #6285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #6285 +/- ##
==========================================
+ Coverage 65.29% 65.35% +0.05%
==========================================
Files 247 247
Lines 57526 57637 +111
Branches 12784 12809 +25
==========================================
+ Hits 37564 37670 +106
- Misses 18070 18142 +72
+ Partials 1892 1825 -67
... and 97 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
|
@mahipv, @gayyappan: please review this pull request.
|
akuzm
reviewed
Nov 6, 2023
akuzm
approved these changes
Nov 6, 2023
jnidzwetzki
force-pushed
the
vectorized_add_datatype
branch
from
d1c8124 to
27d773e
Compare
fabriziomello
approved these changes
Nov 8, 2023
This patch adds the support for the dynamic detection of the data type for a vectorized aggregate. In addition, it removes the hard-coded integer data type and initializes the decompression_map properly. This also fixes an invalid memory access.
jnidzwetzki
force-pushed
the
vectorized_add_datatype
branch
from
27d773e to
6e5072e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the support for the dynamic detection of the data type for a vectorized aggregate. In addition, it removes the hard-coded integer data type and initializes the decompression_map properly. This also fixes an invalid memory access.
Failed Sanitizer run: https://github.com/timescale/timescaledb/actions/runs/6751417152/job/18355481965
Fixed Sanitizer run: https://github.com/timescale/timescaledb/actions/runs/6771930209/job/18403409265?pr=6285
Disable-check: force-changelog-file