Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the timescaledb_fdw foreign data wrapper #6413

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

svenklemm
Copy link
Member

@svenklemm svenklemm commented Dec 12, 2023

This is the fdw implementation that was used for communication between multinode instances.

Disable-check: force-changelog-file

Copy link

@jnidzwetzki, @konskov: please review this pull request.

Powered by pull-review

@svenklemm svenklemm force-pushed the multinode2 branch 3 times, most recently from c5420c8 to aceae3e Compare December 13, 2023 06:46
This is the fdw implementation that was used for communication
between multinode instances.
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (4e17247) 67.60% compared to head (aceae3e) 72.61%.

Files Patch % Lines
tsl/src/debug.c 0.00% 2 Missing ⚠️
tsl/src/nodes/async_append.c 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6413      +/-   ##
==========================================
+ Coverage   67.60%   72.61%   +5.01%     
==========================================
  Files         232      218      -14     
  Lines       55677    51669    -4008     
  Branches    12324    11453     -871     
==========================================
- Hits        37638    37521     -117     
+ Misses      16197    12343    -3854     
+ Partials     1842     1805      -37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svenklemm svenklemm merged commit c914d19 into timescale:main Dec 13, 2023
63 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants