Account for filters in DecompressChunk row estimates #6563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't account for them at all currently, which leads to weird planning behavior, like the filters not influencing the position of relations in join.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6563 +/- ##
==========================================
- Coverage 79.73% 79.70% -0.04%
==========================================
Files 188 188
Lines 36768 36726 -42
Branches 9295 9280 -15
==========================================
- Hits 29318 29271 -47
- Misses 3112 3126 +14
+ Partials 4338 4329 -9 ☔ View full report in Codecov by Sentry. |
…ially_compressed-*
…ially_compressed-*
…ially_compressed-*
akuzm
commented
Jan 25, 2024
Comment on lines
18
to
21
| INSERT INTO mapc_test | ||
| SELECT time, device, device * 0.1 | ||
| FROM generate_series('2020-01-02'::timestamptz,'2020-01-18'::timestamptz,'6 hour') time, | ||
| generate_series(1,3) device; | ||
| FROM generate_series('2020-01-02'::timestamptz,'2020-01-15'::timestamptz,'4 second') time, | ||
| generate_series(1,10) device; |
There was a problem hiding this comment.
After adding the missed ANALYZE, I had to add much more rows to keep the old plans. Also renamed it to something less generic and removed the third chunk which doesn't really add coverage.
|
@mkindahl, @antekresic: please review this pull request.
|
2 tasks
svenklemm
approved these changes
Jan 25, 2024
antekresic
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't account for them at all currently, which leads to weird planning behavior, like the filters not influencing the position of relations in join. We don't normally have the statistics on uncompressed tables of compressed chunks, so these estimates will be using the Postgres defaults that are chosen based on the kind of filter.
Disable-check: force-changelog-file