-
Notifications
You must be signed in to change notification settings - Fork 887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GUC for hypercore_use_access_method default #7412
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7412 +/- ##
==========================================
- Coverage 80.06% 76.68% -3.38%
==========================================
Files 190 228 +38
Lines 37181 42108 +4927
Branches 9450 10562 +1112
==========================================
+ Hits 29770 32292 +2522
- Misses 2997 5755 +2758
+ Partials 4414 4061 -353 ☔ View full report in Codecov by Sentry. |
c44ff78
to
1554e7c
Compare
This is on top of #7411 and will be merge after that PR is merged. |
1682a51
to
9c1be72
Compare
9c1be72
to
b6fac8c
Compare
b6fac8c
to
d7ea921
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some nits.
d16246c
to
a60ea0c
Compare
a60ea0c
to
3956e9f
Compare
Add the GUC `timescaledb.hypercore_use_access_method` for dealing with the default value to use for functions accepting the `hypercore_use_access_method` parameter (`compress_chunk`, `add_compression_policy`, etc.) Value can be "on" (use the hypercore access method) or "off" (do not use the hypercore access method) and can be overridden by the parameter to the functions by explicitly providing a value. If no value is chosen, the default will be picked. Make GUC a boolean instead
3956e9f
to
48a64e6
Compare
This release contains performance improvements and bug fixes since the 2.17.2 release. We recommend that you upgrade at the next available opportunity. **Features** * timescale#7271 Hypercore table access method * timescale#7271 Push down ORDER BY in real time continuous aggregate queries * timescale#7295: Support ALTER TABLE SET ACCESS METHOD on hypertable. * timescale#7390 Disable custom hashagg planner code * timescale#7411 Change parameter name to enable Hypercore TAM * timescale#7412 Add GUC for hypercore_use_access_method default * timescale#7413: Add GUC for segmentwise recompression. **Bugfixes** * timescale#7378 Remove obsolete job referencing policy_job_error_retention * timescale#7409 Update bgw job table when altering procedure * timescale#7426 Fix datetime parsing error in chunk constraint creation * timescale#7432 Verify that heap tuple is valid before using * timescale#7434 Fixes segfault when internally set the replica identity for a given chunk **Thanks** * @bharrisau for reporting the segfault when creating chunks * @pgloader for reporting an issue an internal background job
This release contains performance improvements and bug fixes since the 2.17.2 release. We recommend that you upgrade at the next available opportunity. **Features** * timescale#7271 Hypercore table access method * timescale#7271 Push down ORDER BY in real time continuous aggregate queries * timescale#7295: Support ALTER TABLE SET ACCESS METHOD on hypertable. * timescale#7390 Disable custom hashagg planner code * timescale#7411 Change parameter name to enable Hypercore TAM * timescale#7412 Add GUC for hypercore_use_access_method default * timescale#7413: Add GUC for segmentwise recompression. * timescale#7455: Support DROP NOT NULL on compressed hypertables **Bugfixes** * timescale#7378 Remove obsolete job referencing policy_job_error_retention * timescale#7409 Update bgw job table when altering procedure * timescale#7426 Fix datetime parsing error in chunk constraint creation * timescale#7432 Verify that heap tuple is valid before using * timescale#7434 Fixes segfault when internally set the replica identity for a given chunk **Thanks** * @bharrisau for reporting the segfault when creating chunks * @pgloader for reporting an issue an internal background job
Add the GUC
timescaledb.hypercore_use_access_method
for dealing with the default value to use for functions accepting thehypercore_use_access_method
parameter (compress_chunk
,add_compression_policy
, etc.)Value can be "on" (use the hypercore access method) or "off" (do not use the hypercore access method) and can be overridden by the parameter to the functions by explicitly providing a value. If no value is chosen, the default will be picked.