Use America/Los_Angeles in tests instead of PST8PDT #7416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow the PG upstream changes in light of the upcoming timezone updates. This should fix our regression tests on latest PG snapshots. postgres/postgres@2b94ee5
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7416 +/- ##
==========================================
+ Coverage 80.06% 82.56% +2.49%
==========================================
Files 190 229 +39
Lines 37181 42740 +5559
Branches 9450 10739 +1289
==========================================
+ Hits 29770 35287 +5517
- Misses 2997 3173 +176
+ Partials 4414 4280 -134 ☔ View full report in Codecov by Sentry. |
|
Setting the timezone in all the cagg files was a workaround for a problem with cagg refresh which has been fixed so we can probably remove the explicit timezone from the cagg test files again. |
Removed. |
akuzm
added
the
force-auto-backport
erimatnor
approved these changes
Nov 6, 2024
Yep |
svenklemm
approved these changes
Nov 6, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Nov 6, 2024
Follow the PG upstream changes in light of the upcoming timezone updates. This should fix our regression tests on latest PG snapshots. postgres/postgres@2b94ee5 (cherry picked from commit 6803dd8)
timescale-automation
pushed a commit
that referenced
this pull request
Nov 6, 2024
Follow the PG upstream changes in light of the upcoming timezone updates. This should fix our regression tests on latest PG snapshots. postgres/postgres@2b94ee5 (cherry picked from commit 6803dd8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow the PG upstream changes in light of the upcoming timezone updates. This should fix our regression tests on latest PG snapshots.
postgres/postgres@2b94ee5
Example of the failing test on main: https://github.com/timescale/timescaledb/actions/runs/11666186287/job/32480586544
Disable-check: force-changelog-file
test