Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ERRCODE_INTERNAL_ERROR with appropriate code #7417

Merged
merged 7 commits into from
Nov 12, 2024
Merged

Conversation

akuzm
Copy link
Member

@akuzm akuzm commented Nov 5, 2024

Anything that can be triggered by user action or environment conditions is not an internal program error.

This is only a small part of the existing problems: ci_stats=# select error, count(*) from ipe where job_date > now() - interval '1 month' group by error order by count(*) desc limit 100;

Disable-check: force-changelog-file

akuzm added 4 commits November 5, 2024 16:05
Anything that can be triggered by user action or environment conditions
is not an internal program error.
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 12 lines in your changes missing coverage. Please review.

Project coverage is 82.48%. Comparing base (59f50f2) to head (e86b9a3).
Report is 585 commits behind head on main.

Files with missing lines Patch % Lines
src/chunk_index.c 33.33% 1 Missing and 3 partials ⚠️
src/ts_catalog/tablespace.c 0.00% 0 Missing and 2 partials ⚠️
src/nodes/chunk_dispatch/chunk_dispatch.c 0.00% 0 Missing and 1 partial ⚠️
src/with_clause_parser.c 0.00% 0 Missing and 1 partial ⚠️
tsl/src/bgw_policy/compression_api.c 0.00% 0 Missing and 1 partial ⚠️
tsl/src/nodes/decompress_chunk/exec.c 0.00% 1 Missing ⚠️
tsl/src/nodes/decompress_chunk/planner.c 0.00% 0 Missing and 1 partial ⚠️
tsl/src/nodes/frozen_chunk_dml/frozen_chunk_dml.c 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7417      +/-   ##
==========================================
+ Coverage   80.06%   82.48%   +2.41%     
==========================================
  Files         190      229      +39     
  Lines       37181    42729    +5548     
  Branches     9450    10739    +1289     
==========================================
+ Hits        29770    35246    +5476     
- Misses       2997     3192     +195     
+ Partials     4414     4291     -123     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akuzm akuzm enabled auto-merge (squash) November 7, 2024 14:39
@akuzm akuzm merged commit 062a119 into timescale:main Nov 12, 2024
50 of 53 checks passed
@akuzm akuzm deleted the ipe branch November 12, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants