Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use version on Windows from config generated file #7477

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mkindahl
Copy link
Contributor

@mkindahl mkindahl commented Nov 21, 2024

Disable-check: force-changelog-file

@mkindahl mkindahl self-assigned this Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.13%. Comparing base (59f50f2) to head (8b8d210).
Report is 620 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7477      +/-   ##
==========================================
+ Coverage   80.06%   82.13%   +2.07%     
==========================================
  Files         190      230      +40     
  Lines       37181    43129    +5948     
  Branches     9450    10846    +1396     
==========================================
+ Hits        29770    35426    +5656     
- Misses       2997     3383     +386     
+ Partials     4414     4320      -94     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@mkindahl mkindahl force-pushed the windows-use-config branch 2 times, most recently from 950cfad to 347bef3 Compare November 21, 2024 17:20
@mkindahl mkindahl changed the title Use latest version from config generated file Use version on Windows from config generated file Nov 22, 2024
@mkindahl mkindahl marked this pull request as ready for review November 25, 2024 14:15
@mkindahl
Copy link
Contributor Author

Windows tests are failing right now since the version is not available in Chocolatey. We can merge once it is there (and the tests pass).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant