Use version on Windows from config generated file #7477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7477 +/- ##
==========================================
+ Coverage 80.06% 82.09% +2.03%
==========================================
Files 190 230 +40
Lines 37181 43188 +6007
Branches 9450 10867 +1417
==========================================
+ Hits 29770 35457 +5687
- Misses 2997 3402 +405
+ Partials 4414 4329 -85 ☔ View full report in Codecov by Sentry. |
mkindahl
force-pushed
the
windows-use-config
branch
2 times, most recently
from
950cfad to
347bef3
Compare
mkindahl
changed the title
mkindahl
force-pushed
the
windows-use-config
branch
from
347bef3 to
8b8d210
Compare
|
Windows tests are failing right now since the version is not available in Chocolatey. We can merge once it is there (and the tests pass). |
mkindahl
force-pushed
the
windows-use-config
branch
2 times, most recently
from
d4e65dd to
79a6bc7
Compare
mkindahl
force-pushed
the
windows-use-config
branch
from
79a6bc7 to
2401cb9
Compare
mkindahl
force-pushed
the
windows-use-config
branch
from
2401cb9 to
6ea9f6a
Compare
antekresic
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable-check: force-changelog-file