Add workaround for pg_depend bug in PG < 15.4 #7508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PostgreSQL versions prior to 15.4 didn't properly update object dependencies when setting a new access method on a table. The fix for the bug is found in this commit: postgres/postgres@97d8910 The `hypercore_create` test failed on buggy PG versions (e.g., 15.0) due to wrong contents of pg_depend showing up in test output when converting a table from Hypercore TAM back to regular heap. This change adds a workaround that updates pg_depend with the correct information when compiling against PG versions that suffer from the bug.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7508 +/- ##
==========================================
+ Coverage 80.06% 82.14% +2.07%
==========================================
Files 190 230 +40
Lines 37181 43190 +6009
Branches 9450 10868 +1418
==========================================
+ Hits 29770 35478 +5708
- Misses 2997 3387 +390
+ Partials 4414 4325 -89 ☔ View full report in Codecov by Sentry. |
fabriziomello
approved these changes
Dec 2, 2024
mkindahl
approved these changes
Dec 3, 2024
Comment on lines
+790
to
+800
| #if (PG_VERSION_NUM < 150004) | ||
| /* Fix for PostgreSQL bug where pg_depend was not updated to reflect the | ||
| * new dependency between AM and relation. See related PG fix here: | ||
| * https://github.com/postgres/postgres/commit/97d89101045fac8cb36f4ef6c08526ea0841a596 */ | ||
| if (changeDependencyFor(RelationRelationId, relid, AccessMethodRelationId, amoid, new_amoid) != | ||
| 1) | ||
| elog(ERROR, | ||
| "could not change access method dependency for relation \"%s.%s\"", | ||
| get_namespace_name(get_rel_namespace(relid)), | ||
| get_rel_name(relid)); | ||
| #endif |
There was a problem hiding this comment.
Since this was reported in 16beta1 it seems like it should be fixed in all GA versions of PostgreSQL after 16.0, so double-checking that it is indeed the case and this is the result. You might want to add a comment to why this is not necessary to check for later versions, but IMHO this is entirely optional since it was fixed before the GA release of the other versions.
mats@fury:~/repos/postgres$ git log --grep "Fix pg_depend entry" --oneline
97d8910104 Fix pg_depend entry to AMs after ALTER TABLE .. SET ACCESS METHOD
mats@fury:~/repos/postgres$ git tag --contains 97d8910104
REL_16_0
REL_16_1
REL_16_2
REL_16_3
REL_16_4
REL_16_5
REL_16_6
REL_16_BETA3
REL_16_RC1
REL_17_0
REL_17_1
REL_17_2
REL_17_BETA1
REL_17_BETA2
REL_17_BETA3
REL_17_RC1There was a problem hiding this comment.
Thank you for double-checking.
|
Automated backport to 2.17.x not done: cherry-pick failed. Git status |
timescale-automation
added
the
auto-backport-not-done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PostgreSQL versions prior to 15.4 didn't properly update object dependencies when setting a new access method on a table. The fix for the bug is found in this commit:
postgres/postgres@97d8910
The
hypercore_createtest failed on buggy PG versions (e.g., 15.0) due to wrong contents of pg_depend showing up in test output when converting a table from Hypercore TAM back to regular heap.This change adds a workaround that updates pg_depend with the correct information when compiling against PG versions that suffer from the bug.
Disable-check: force-changelog-file
Disable-check: approval-count