Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify flakes table for jobs #7519

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

mkindahl
Copy link
Contributor

@mkindahl mkindahl commented Dec 5, 2024

This adds a generated column for extracting the version from the job name. It will read anything that matches PG<number><alphanumeric> or PG<number>.<number> and generate a version string. If the first pattern matches, it will generate <number>.x as string, signifying that this is an unknown minor version.

Disable-check: force-changelog-file, approval-count

@mkindahl mkindahl requested a review from akuzm December 5, 2024 07:55
@mkindahl mkindahl self-assigned this Dec 5, 2024
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.17%. Comparing base (59f50f2) to head (6f3803d).
Report is 641 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7519      +/-   ##
==========================================
+ Coverage   80.06%   82.17%   +2.11%     
==========================================
  Files         190      230      +40     
  Lines       37181    43191    +6010     
  Branches     9450    10869    +1419     
==========================================
+ Hits        29770    35494    +5724     
- Misses       2997     3378     +381     
+ Partials     4414     4319      -95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkindahl mkindahl marked this pull request as ready for review December 5, 2024 09:54
This adds a generated column for extracting the version from the job
name. It will read anything that matches `PG<number><alphanumeric>` or
`PG<number>.<number>` and generate a version string. If the first
pattern matches, it will generate `<number>.x` as string, signifying
that this is an unknown minor version.
@mkindahl mkindahl force-pushed the record-flake-version branch from 71d0d66 to 6f3803d Compare December 5, 2024 12:03
@mkindahl mkindahl enabled auto-merge (rebase) December 5, 2024 13:18
@mkindahl
Copy link
Contributor Author

mkindahl commented Dec 5, 2024

Merging with one approval since this is only CI.

@mkindahl mkindahl merged commit 396caf6 into timescale:main Dec 5, 2024
55 of 57 checks passed
@mkindahl mkindahl deleted the record-flake-version branch December 5, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants