Fix flaky reorder regression test take 2 #7538
Open
+2
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In timescale#7509 we added manual VACUUM in all involved relations to avoid flaky output tests. But looks like it is not working very well specially on Windows builds, so now we're removing the output `found 0 removable, 0 nonremovable row versions in 0 pages` to have a more predictable output test. https://github.com/timescale/timescaledb/actions/runs/12322325859/job/34395659212?pr=7533#step:17:24
|
@mkindahl, @antekresic: please review this pull request.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7538 +/- ##
==========================================
+ Coverage 80.06% 82.18% +2.12%
==========================================
Files 190 230 +40
Lines 37181 43252 +6071
Branches 9450 10875 +1425
==========================================
+ Hits 29770 35548 +5778
- Misses 2997 3385 +388
+ Partials 4414 4319 -95 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #7509 we added manual VACUUM in all involved relations to avoid flaky output tests.
But looks like it is not working very well specially on Windows builds, so now we're removing the output
found 0 removable, 0 nonremovable row versions in 0 pagesto have a more predictable output test.https://github.com/timescale/timescaledb/actions/runs/12322325859/job/34395659212?pr=7533#step:17:24
Disable-check: force-changelog-file
Disable-check: approval-count