Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OffsetInMilliseconds is type long in AudioItemStream.cs #266

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Rossbro2
Copy link

@Rossbro2 Rossbro2 requested a review from timheuer as a code owner April 29, 2024 19:32
Copy link

stale bot commented Jun 28, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 28, 2024
@Rossbro2
Copy link
Author

@timheuer any update on this?

@stale stale bot removed the wontfix label Jun 28, 2024
@timheuer
Copy link
Owner

My concern is a breaking change only. I'd have to major version bounce it. I don't have telemetry built in so hard to tell if anyone today is even impacted really.

Copy link

stale bot commented Aug 28, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Aug 28, 2024
@Rossbro2
Copy link
Author

My concern is a breaking change only. I'd have to major version bounce it. I don't have telemetry built in so hard to tell if anyone today is even impacted really.

@timheuer is there a reason to avoid a version bump? I wouldn't think that'd be a reason to prevent fixing it

@stale stale bot removed the wontfix label Aug 28, 2024
Copy link

stale bot commented Oct 28, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 28, 2024
@Rossbro2
Copy link
Author

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

#266 (comment)

@stale stale bot removed the wontfix label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants