-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OffsetInMilliseconds
is type long
in AudioItemStream.cs
#266
base: master
Are you sure you want to change the base?
Conversation
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@timheuer any update on this? |
My concern is a breaking change only. I'd have to major version bounce it. I don't have telemetry built in so hard to tell if anyone today is even impacted really. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@timheuer is there a reason to avoid a version bump? I wouldn't think that'd be a reason to prevent fixing it |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
PlaybackState.OffsetInMilliseconds and AudioPlayerRequest.OffsetInMilliseconds both use type
long
, asAudioItemStream
should as well as per Alexa developer documentation.