Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade badger to v4 #91

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

upgrade badger to v4 #91

wants to merge 1 commit into from

Conversation

coyzeng
Copy link

@coyzeng coyzeng commented Mar 12, 2023

Upgrade badger to v4
Upgrade go to 1.19

Copy link
Owner

@timshannon timshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me. I think the checks are just failing because the workflow is pointing at an older go version which can't build this version.

So you can either bump the go version in the workflow to the latest go (1.20.2) or I can grab your changes and move it in myself.

Thanks,

@timshannon
Copy link
Owner

Actually, I'm getting test failures when running the tests on my machine, are you also seeing this?

badgerholdv4$ go test
store_test.go:158:

        exp: &errors.errorString{s:"unexpected EOF"}

        got: <nil>

--- FAIL: TestIssue70TypePrefixCollisionWithV3 (0.02s)
badger 2023/03/14 08:44:58 INFO: All 0 tables opened in 0s
badger 2023/03/14 08:44:58 INFO: Discard stats nextEmptySlot: 0
badger 2023/03/14 08:44:58 INFO: Set nextTxnTs to 0
badger 2023/03/14 08:44:58 INFO: Lifetime L0 stalled for: 0s
badger 2023/03/14 08:44:58 INFO:
Level 0 [ ]: NumTables: 01. Size: 514 B of 0 B. Score: 0.00->0.00 StaleData: 0 B Target FileSize: 64 MiB
Level 1 [ ]: NumTables: 00. Size: 0 B of 10 MiB. Score: 0.00->0.00 StaleData: 0 B Target FileSize: 2.0 MiB
Level 2 [ ]: NumTables: 00. Size: 0 B of 10 MiB. Score: 0.00->0.00 StaleData: 0 B Target FileSize: 2.0 MiB
Level 3 [ ]: NumTables: 00. Size: 0 B of 10 MiB. Score: 0.00->0.00 StaleData: 0 B Target FileSize: 2.0 MiB
Level 4 [ ]: NumTables: 00. Size: 0 B of 10 MiB. Score: 0.00->0.00 StaleData: 0 B Target FileSize: 2.0 MiB
Level 5 [ ]: NumTables: 00. Size: 0 B of 10 MiB. Score: 0.00->0.00 StaleData: 0 B Target FileSize: 2.0 MiB
Level 6 [B]: NumTables: 00. Size: 0 B of 10 MiB. Score: 0.00->0.00 StaleData: 0 B Target FileSize: 2.0 MiB
Level Done
FAIL
exit status 1
FAIL    github.com/timshannon/badgerhold/v4     13.176s

@coyzeng
Copy link
Author

coyzeng commented Mar 24, 2023

I'll fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants