VReplication workflows: retry "wrong tablet type" errors (vitessio#16645

)

Signed-off-by: Rohit Nayak <[email protected]>

go/vt/vttablet/tabletmanager/vreplication/utils.go

@@ -134,7 +134,12 @@ func isUnrecoverableError(err error) bool {
 	if err == nil {
 		return false
 	}
-	if vterrors.Code(err) == vtrpcpb.Code_FAILED_PRECONDITION {
+	switch vterrors.Code(err) {
+	case vtrpcpb.Code_FAILED_PRECONDITION:
+		if vterrors.RxWrongTablet.MatchString(err.Error()) {
+			// If the chosen tablet type picked changes, say due to PRS/ERS, we should retry.
+			return false
+		}
 		return true
 	}
 	sqlErr, isSQLErr := sqlerror.NewSQLErrorFromError(err).(*sqlerror.SQLError)

go/vt/vttablet/tabletmanager/vreplication/utils_test.go

@@ -17,17 +17,21 @@ limitations under the License.
 package vreplication
 
 import (
+	"errors"
 	"fmt"
 	"strings"
 	"testing"
 
 	"github.com/stretchr/testify/require"
 
+	"vitess.io/vitess/go/mysql/sqlerror"
 	"vitess.io/vitess/go/sqltypes"
 	"vitess.io/vitess/go/textutil"
 	"vitess.io/vitess/go/vt/binlog/binlogplayer"
+	"vitess.io/vitess/go/vt/vterrors"
 
 	binlogdatapb "vitess.io/vitess/go/vt/proto/binlogdata"
+	vtrpcpb "vitess.io/vitess/go/vt/proto/vtrpc"
 )
 
 func TestInsertLogTruncation(t *testing.T) {
@@ -97,3 +101,60 @@ func TestInsertLogTruncation(t *testing.T) {
 		})
 	}
 }
+
+// TestIsUnrecoverableError tests the different error cases for isUnrecoverableError().
+func TestIsUnrecoverableError(t *testing.T) {
+	if runNoBlobTest {
+		t.Skip()
+	}
+
+	type testCase struct {
+		name     string
+		err      error
+		expected bool
+	}
+
+	testCases := []testCase{
+		{
+			name:     "Nil error",
+			err:      nil,
+			expected: false,
+		},
+		{
+			name:     "vterrors.Code_FAILED_PRECONDITION",
+			err:      vterrors.Errorf(vtrpcpb.Code_FAILED_PRECONDITION, "test error"),
+			expected: true,
+		},
+		{
+			name:     "vterrors.Code_FAILED_PRECONDITION, WrongTablet",
+			err:      vterrors.Errorf(vtrpcpb.Code_FAILED_PRECONDITION, "%s: %v, want: %v or %v", vterrors.WrongTablet, "PRIMARY", "REPLICA", nil),
+			expected: false,
+		},
+		{
+			name:     "Non-SQL error",
+			err:      errors.New("non-SQL error"),
+			expected: false,
+		},
+		{
+			name:     "SQL error with ERUnknownError",
+			err:      sqlerror.NewSQLError(sqlerror.ERUnknownError, "test SQL error", "test"),
+			expected: false,
+		},
+		{
+			name:     "SQL error with ERAccessDeniedError",
+			err:      sqlerror.NewSQLError(sqlerror.ERAccessDeniedError, "access denied", "test"),
+			expected: true,
+		},
+		{
+			name:     "SQL error with ERDataOutOfRange",
+			err:      sqlerror.NewSQLError(sqlerror.ERDataOutOfRange, "data out of range", "test"),
+			expected: true,
+		},
+	}
+	for _, tc := range testCases {
+		t.Run(tc.name, func(t *testing.T) {
+			result := isUnrecoverableError(tc.err)
+			require.Equal(t, tc.expected, result)
+		})
+	}
+}