Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 Docs Mobile - Header Changes #2478

Merged
merged 2 commits into from
Nov 19, 2024
Merged

💄 Docs Mobile - Header Changes #2478

merged 2 commits into from
Nov 19, 2024

Conversation

joshbermanssw
Copy link
Contributor

As per #2333 there were some inconsistent overlaps of content in the docs header.

Test passed by @bettybondoc fixed it with her

Screenshot 2024-11-18 at 4 03 20 pm
Figure: New Header

Screenshot 2024-11-18 at 4 05 51 pm
Figure: Old Header

@joshbermanssw joshbermanssw requested a review from a team as a code owner November 18, 2024 05:06
Copy link

vercel bot commented Nov 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tina-io ❌ Failed (Inspect) Nov 19, 2024 10:06pm

Copy link
Contributor

@isaaclombardssw isaaclombardssw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing – also THANK YOU such a good change

@joshbermanssw joshbermanssw merged commit 0774ecf into main Nov 19, 2024
2 of 4 checks passed
@joshbermanssw joshbermanssw deleted the docs-header-ui branch November 19, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants