Refactor run_protocol #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waxlamp
reviewed
May 19, 2021
Nothing specific, just wanted to check if this would make sense (or if it seems unnecessary) from a software engineering and code structure perspective. |
as6520
reviewed
May 25, 2021
| if file_list is not None: | ||
| features_dict, logits_dict = algorithm.execute( | ||
| "FeatureExtraction", file_list | ||
| try: |
There was a problem hiding this comment.
Should this be moved in round too? This would require changing the return type of _run_round to bool
| pass | ||
| else: | ||
| ( | ||
| algo_test_data["features_dict"], |
There was a problem hiding this comment.
I would recommend using update here rather than assigning since you would need to aggregate features across multiple rounds to save them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to move the per-round logic to its own method outside of
run_protocolto more clearly delineate what's happening within rounds (as opposed to within tests) and to improve readability of therun_protocolmethod. This refactoring should not change any of the core logic or functionality.Depends on #14.