Handle nil pointer potential:

As the Hardware spec.metadata and spec.metadata.instance are not required in the hardware object they could be nil. Handle checking this so we don't nil pointer panic. Signed-off-by: Jacob Weinstock <[email protected]>
tinkerbell · Nov 8, 2024 · 2288856 · 2288856
1 parent 4600371
commit 2288856
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/internal/backend/kubernetes/backend.go b/internal/backend/kubernetes/backend.go
@@ -162,7 +162,7 @@ type listerClient interface {
 func toEC2Instance(hw tinkv1.Hardware) ec2.Instance {
 	var i ec2.Instance
 
-	if hw.Spec.Metadata.Instance != nil {
+	if hw.Spec.Metadata != nil && hw.Spec.Metadata.Instance != nil {
 		i.Metadata.InstanceID = hw.Spec.Metadata.Instance.ID
 		i.Metadata.Hostname = hw.Spec.Metadata.Instance.Hostname
 		i.Metadata.LocalHostname = hw.Spec.Metadata.Instance.Hostname
@@ -195,7 +195,7 @@ func toEC2Instance(hw tinkv1.Hardware) ec2.Instance {
 		}
 	}
 
-	if hw.Spec.Metadata.Facility != nil {
+	if hw.Spec.Metadata != nil && hw.Spec.Metadata.Facility != nil {
 		i.Metadata.Plan = hw.Spec.Metadata.Facility.PlanSlug
 		i.Metadata.Facility = hw.Spec.Metadata.Facility.FacilityCode
 	}