Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static ipam to kernel parameters for ISO patching: #558

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jacobweinstock
Copy link
Member

Description

This adds static IPAM to kernel parameters when patching an ISO.

Why is this needed

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

This adds static IPAM to kernel parameters
when patching an ISO.

Signed-off-by: Jacob Weinstock <[email protected]>
@jacobweinstock jacobweinstock changed the title Add static ipam to kernel parameters: Add static ipam to kernel parameters for ISO patching: Nov 22, 2024
CLI Flag to enable/disable ISO static
IPAM.

Signed-off-by: Jacob Weinstock <[email protected]>
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 63 lines in your changes missing coverage. Please review.

Project coverage is 49%. Comparing base (108bffc) to head (ea85fe0).

Files with missing lines Patch % Lines
internal/iso/iso.go 21% 62 Missing ⚠️
cmd/smee/main.go 0% 1 Missing ⚠️
Additional details and impacted files
@@         Coverage Diff         @@
##           main   #558   +/-   ##
===================================
- Coverage    50%    49%   -1%     
===================================
  Files        27     27           
  Lines      2976   3032   +56     
===================================
+ Hits       1493   1509   +16     
- Misses     1428   1470   +42     
+ Partials     55     53    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant