add libXfont2 support with a compile-time switch #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
while doing this, I also found that there is a function 'miImageGlyphBlt' in mi/miglblt.c, which is declared static(_X_EXPORT), only referenced in mi/mi.h, and never called anywhere. |
rofl0r
reviewed
Nov 15, 2024
| @@ -179,7 +179,11 @@ XFree86BigfontExtensionInit() | |||
| + (unsigned int) (65536.0 / (RAND_MAX + 1.0) * rand()); | |||
| /* fprintf(stderr, "signature = 0x%08X\n", signature); */ | |||
|
|
|||
| #ifdef XFONT2 | |||
| FontShmdescIndex = xfont2_allocate_font_private_index(); | |||
| #else | |||
There was a problem hiding this comment.
since all xfont2 specific functions seem to behave identically, except for the name, i'd add a xfont2_compat.h which looks like
#ifdef XFONT2
#define AllocateFontPrivateIndex xfont2_allocate_font_private_index
...
#endifthat way the ifdefs are in a single place and not littered all over the code.
(one could also use function-like macros)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #12, but with a compile time switch between libXfont1 and libXfont2.
Defaults to libXfont1