Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TINY-10688: Support using pnpm-workspace.yaml #141

Merged
merged 6 commits into from
Mar 6, 2024

Conversation

danoaky-tiny
Copy link
Contributor

@danoaky-tiny danoaky-tiny commented Feb 29, 2024

Related Ticket: TINY-10688

Description of Changes:
If the workspaces prop inside of the project's package.json is unused, check if there's a pnpm-workspace.yaml file then use pnpm list -r --only-projects --json to find workspaces instead.

Pre-checks:

  • Changelog entry added
  • package.json versions have not been changed (done by Lerna on release)
  • Tests have been added (if applicable)

Before merging:

  • Ensure internal dependencies are on appropriate versions
    • For stable releases, all dependencies must be stable
    • For release candidates, all dependencies must be release candidates or stable

Copy link
Member

@TheSpyder TheSpyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note bedrock doesn't have an automated release process, so you'll probably need help from an admin to publish once we're ready to do a new release

modules/server/src/main/ts/bedrock/server/RunnerRoutes.ts Outdated Show resolved Hide resolved
@danoaky-tiny danoaky-tiny merged commit 1fac4f6 into master Mar 6, 2024
5 checks passed
@danoaky-tiny danoaky-tiny deleted the feature/TINY-10688 branch March 6, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants