Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TINY-11415: added static service worker #147

Merged
merged 3 commits into from
Oct 24, 2024
Merged

TINY-11415: added static service worker #147

merged 3 commits into from
Oct 24, 2024

Conversation

spocke
Copy link
Member

@spocke spocke commented Oct 17, 2024 •
edited
Loading

Related Ticket: TINY-11415

Description of Changes:

  • Added the mswjs service worker file as a node resolved resource didn't want to make bedrock dependent on the whole mswjs library just for this one file so if it exists in the projects node_modules then that will be served.

Pre-checks:

  • Changelog entry added
  • package.json versions have not been changed (done by Lerna on release)
  • Tests have been added (if applicable)

Before merging:

  • Ensure internal dependencies are on appropriate versions
    • For stable releases, all dependencies must be stable
    • For release candidates, all dependencies must be release candidates or stable

@spocke spocke requested a review from a team as a code owner October 17, 2024 17:34
@spocke spocke requested review from a team, lorenzo-pomili, hamza0867, HAFRMO and ztomaszyk and removed request for a team October 17, 2024 18:02
@spocke spocke merged commit 9205720 into master Oct 24, 2024
5 checks passed
@spocke spocke deleted the feature/TINY-11415 branch October 24, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ltrouton ltrouton ltrouton approved these changes

@lorenzo-pomili lorenzo-pomili lorenzo-pomili approved these changes

@TheSpyder TheSpyder TheSpyder approved these changes

@hamza0867 hamza0867 Awaiting requested review from hamza0867 hamza0867 was automatically assigned from tinymce/high-velocity

@HAFRMO HAFRMO Awaiting requested review from HAFRMO HAFRMO was automatically assigned from tinymce/high-velocity

@ztomaszyk ztomaszyk Awaiting requested review from ztomaszyk ztomaszyk was automatically assigned from tinymce/high-velocity

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spocke @TheSpyder @lorenzo-pomili @ltrouton