Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC-2573: Convert headings in changelog to xref links that point to their respective release notes. #3509

Merged
merged 2 commits into from
Nov 18, 2024
Merged

DOC-2573: Convert headings in changelog to xref links that point to their respective release notes. #3509

merged 2 commits into from
Nov 18, 2024

Conversation

abhinavgandham
Copy link

@abhinavgandham abhinavgandham commented Nov 14, 2024 •
edited by kemister85
Loading

Ticket: DOC-2573

Site: Staging branch

Changes:

  • Converted the headings in the changelog page to be xref links instead.

Pre-checks:

  • Branch prefixed with feature/<version>/, hotfix/<version>/, staging/<version>/, or release/<version>/.

Review:

  • Documentation Team Lead has reviewed

FarzadHayat
FarzadHayat approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@FarzadHayat FarzadHayat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work 👍

kemister85
kemister85 approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@kemister85 kemister85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

@kemister85 kemister85 changed the title Converted headings in changelog to xref links that point to their res… DOC-2573: Convert headings in changelog to xref links that point to their respective release notes. Nov 18, 2024
@kemister85 kemister85 merged commit cdb5130 into tinymce/7 Nov 18, 2024
5 checks passed
@kemister85 kemister85 deleted the hotfix/7/DOC-2573 branch November 18, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kemister85 kemister85 kemister85 approved these changes

@FarzadHayat FarzadHayat FarzadHayat approved these changes

@soritaheng soritaheng Awaiting requested review from soritaheng soritaheng is a code owner

@LewisAtTiny LewisAtTiny Awaiting requested review from LewisAtTiny LewisAtTiny is a code owner

@MitchC1999 MitchC1999 Awaiting requested review from MitchC1999 MitchC1999 is a code owner automatically assigned from tinymce/documentation-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abhinavgandham @FarzadHayat @kemister85